chore bump #233
chore bump #233
Conversation
WalkthroughThe recent updates across multiple Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant A as Application
participant C as injective-cosmwasm
U->>A: Initiate Build
A->>C: Fetch injective-cosmwasm (v0.2.18 or v0.2.22)
C-->>A: Provide Dependencies
A-->>U: Build Complete
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- contracts/injective-cosmwasm-mock/Cargo.toml (1 hunks)
Additional comments not posted (1)
contracts/injective-cosmwasm-mock/Cargo.toml (1)
38-38: LGTM! But verify compatibility with the new version.The dependency for
injective-cosmwasmhas been updated to version0.2.18. This change should improve stability and compatibility by using a specific version instead of a local path.However, ensure that the new version does not introduce any breaking changes or incompatibilities.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockcontracts/injective-cosmwasm-mock/Cargo.lockis excluded by!**/*.lock
Files selected for processing (8)
- contracts/atomic-order-example/Cargo.toml (1 hunks)
- contracts/dummy/Cargo.toml (1 hunks)
- packages/injective-cosmwasm/CHANGELOG.md (1 hunks)
- packages/injective-cosmwasm/Cargo.toml (1 hunks)
- packages/injective-cosmwasm/src/exchange/subaccount.rs (1 hunks)
- packages/injective-cosmwasm/src/exchange/types.rs (2 hunks)
- packages/injective-cosmwasm/src/exchange_mock_querier.rs (8 hunks)
- packages/injective-testing/Cargo.toml (1 hunks)
Files skipped from review due to trivial changes (4)
- contracts/atomic-order-example/Cargo.toml
- contracts/dummy/Cargo.toml
- packages/injective-cosmwasm/src/exchange/subaccount.rs
- packages/injective-testing/Cargo.toml
Additional comments not posted (19)
packages/injective-cosmwasm/CHANGELOG.md (4)
8-12: Changelog Update: Version 0.2.24The changes for version
0.2.24are well-documented, including the update tocosmwasm_stdversion2.1.0.
17-18: Changelog Update: Added TestsThe addition of tests for
injective-cosmwasm-mockcovering the functionality ofquerier.rsis well-documented.
21-22: Changelog Update: Fixed Aggregate Volume QueryThe fix for the exchange aggregate volume query to use the correct parsing method is well-documented.
25-27: Changelog Update: Removed ItemsThe removal of grants related queries and the exchange denom decimal query is well-documented.
packages/injective-cosmwasm/Cargo.toml (3)
9-9: Package Version UpdateThe package version has been updated to
0.2.24, indicating a new release.
13-13: Dependency Update: cosmwasm-stdThe
cosmwasm-stddependency has been updated to version2.1.0, which includes new features and improvements.
14-14: Dependency Update: cw-storage-plusThe
cw-storage-plusdependency has been updated to version2.0.0, suggesting enhancements or changes in the storage functionalities.packages/injective-cosmwasm/src/exchange/types.rs (4)
367-368: Addition of KEY_ELEMS ConstantThe addition of the
KEY_ELEMSconstant with a value of42standardizes the number of key elements associated withSubaccountId.
370-373: Return Type Update: from_vec MethodThe return type of the
from_vecmethod has been updated tostd::result::Result<SubaccountId, StdError>, aligning with standard Rust practices for result types.
374-376: New Method: from_sliceThe
from_slicemethod allows direct deserialization from byte slices, enhancing the usability of theSubaccountIdtype.
400-401: Addition of KEY_ELEMS ConstantThe addition of the
KEY_ELEMSconstant with a value of42standardizes the number of key elements associated with&SubaccountId.packages/injective-cosmwasm/src/exchange_mock_querier.rs (8)
257-259: Approved: Explicitly define the fee amount asu128for type safety and clarity.The change to
Coin::new(10u128, "inj")enhances type safety and clarity in monetary calculations.
268-270: Approved: Explicitly define the balance amount asu128for consistency and type safety.The change to
Coin::new(1000000000000000u128, denom)ensures consistency in how responses are created.
273-275: Approved: Explicitly define the balance amount asu128for consistency and type safety.The change to
Coin::new(1000000000000000u128, "inj")ensures consistency in how responses are created.
Line range hint
282-299: Approved: Explicitly define monetary values asu128for consistency and type safety.The changes to
Coin::new(100000000000000000000u128, denom),Coin::new(1000000000000000000000u128, denom), andCoin::new(10000000000000000000u128, denom)ensure consistency in how monetary values are defined.
1264-1266: Approved: Explicitly define the balance amount asu128for type safety and clarity.The change to
Coin::new(0u128, denom.clone())enhances type safety and clarity in balance handling.
1280-1282: Approved: Improve consistency in response creation.The change to
AllBalanceResponse::new(self.balances.to_owned())ensures consistency in how responses are created.
1331-1345: Approved: Enhance type specificity and safety by usingAddrfor the creator parameter.The change to
pub fn create_contract_info_handler(code_id: u64, creator: Addr)enhances type specificity and safety.
1348-1361: Approved: Enhance type specificity and safety by usingAddrfor the creator parameter.The change to
pub fn create_code_id_handler(creator: Addr)enhances type specificity and safety.
Summary by CodeRabbit
injective-cosmwasmpackage to version0.2.24, enhancing functionality and compatibility.SubaccountId, improving usability.injective-cosmwasmpackage version in some areas to ensure stability and reliability.