feat: generated bindings from v1.12.10-testnet for injective-std #219
Conversation
WalkthroughThe recent changes encompass restructuring Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Files skipped from review as they are similar to previous changes (3)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
| @@ -18,7 +18,7 @@ pub struct Coin { | |||
| /// signatures required by gogoproto. | |||
| #[allow(clippy::derive_partial_eq_without_eq)] | |||
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | |||
| #[proto_message(type_url = "/cosmos.base.v1beta1.DecCoinDecCoin")] | |||
| #[proto_message(type_url = "/cosmos.base.v1beta1.DecCoinDecCoinDecCoin")] | |||
| @@ -5,7 +5,7 @@ use osmosis_std_derive::CosmwasmExt; | |||
| /// signatures required by gogoproto. | |||
| #[allow(clippy::derive_partial_eq_without_eq)] | |||
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | |||
| #[proto_message(type_url = "/cosmos.base.v1beta1.CoinCoin")] | |||
| #[proto_message(type_url = "/cosmos.base.v1beta1.CoinCoinCoin")] | |||
gorgos
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 30
Out of diff range and nitpick comments (41)
packages/injective-std/src/types/cosmos/bank/v1beta1.rs (41)
7-8: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
22-23: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
40-41: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
51-52: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
62-63: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
75-76: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
86-87: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
111-112: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
152-153: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
178-179: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
191-192: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
208-209: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
218-219: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
238-239: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
256-257: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
278-279: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
296-297: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
316-317: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
327-328: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
346-347: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
363-364: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
377-378: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
387-388: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
397-398: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
406-407: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
423-424: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
438-439: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
453-454: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
465-466: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
488-489: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
503-504: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
519-520: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
541-542: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
556-557: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
569-570: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
575-576: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
588-589: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
596-597: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
614-615: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
626-627: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
646-647: Ensure consistency in attribute ordering for readability and maintainability.Consider maintaining a consistent order of attributes across different structs for better readability and maintainability. For example, always placing
#[derive(...)]before#[proto_message(...)].
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | ||
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
There was a problem hiding this comment.
Ensure consistency in derive attribute usage.
The derive attributes for serialization traits (::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt) are separated from the core traits (Clone, PartialEq, Eq, ::prost::Message). Consider combining them into a single derive block for better readability and consistency, unless there's a specific reason for separation.
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | ||
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
There was a problem hiding this comment.
Ensure consistency in derive attribute usage.
Similar to the previous comment, consider combining the derive attributes into a single block for the TextProposal struct to maintain consistency and improve readability.
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | ||
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
There was a problem hiding this comment.
Ensure consistency in derive attribute usage.
For the Deposit struct, consider combining the derive attributes into a single block to maintain consistency across the file and improve code readability.
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | ||
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
There was a problem hiding this comment.
Ensure consistency in derive attribute usage.
For the Proposal struct, consider combining the derive attributes into a single block to maintain consistency across the file and improve code readability.
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | ||
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
There was a problem hiding this comment.
Ensure consistency in derive attribute usage.
For the TallyResult struct, consider combining the derive attributes into a single block to maintain consistency across the file and improve code readability.
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | ||
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
There was a problem hiding this comment.
Combine separate derive statements to enhance code maintainability.
- #[derive(Clone, PartialEq, Eq, ::prost::Message)]
- #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)]
+ #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)]This refactoring helps in keeping the code clean and easy to understand.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | |
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | |
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | ||
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
There was a problem hiding this comment.
Merge derive attributes to simplify the code structure.
- #[derive(Clone, PartialEq, Eq, ::prost::Message)]
- #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)]
+ #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)]This change consolidates the attribute declarations, making the code more concise and easier to read.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | |
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] | |
| #[derive(Clone, PartialEq, Eq, ::prost::Message, ::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | ||
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
There was a problem hiding this comment.
Tip
Codebase Verification
Several files in the codebase still use the old function signature. The specific derive attributes (::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt) were not found in any of the checked files, suggesting that the changes are not consistently applied across all modules. It is recommended to review and ensure that the new derive attributes are correctly and uniformly implemented where necessary.
packages/injective-std/src/types/cosmos/auth/module/v1.rspackages/injective-std/src/types/cosmos/authz/module/v1.rspackages/injective-std/src/types/cosmos/bank/module/v1.rspackages/injective-std/src/types/cosmos/distribution/module/v1.rspackages/injective-std/src/types/cosmos/gov/module/v1.rspackages/injective-std/src/types/cosmos/params/module/v1.rspackages/injective-std/src/types/cosmos/feegrant/module/v1.rspackages/injective-std/src/types/cosmwasm/wasm/v1.rspackages/injective-std/src/types/injective/wasmx/v1.rs
Analysis chain
Identical changes to derive attributes as seen in other modules. This standardization enhances clarity and maintainability. Ensure consistency across all modules.
This script aims to list all Rust files in the specified directory and then check each file for the presence of the specific derive attributes, providing a count of occurrences. This approach ensures that no files are missed and gives a clear indication of where the attributes are used.
This script uses xargs to handle the output of find more robustly, ensuring that each file is properly checked for the presence of the specific derive attributes. This approach should avoid the file descriptor issue encountered in the previous script.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the changes to derive attributes in `module/v1.rs` are consistently applied across all modules in the project.
# Find all Rust files in the `types` directory and check for consistent application of the new derive attribute strategy.
rg --files-with-matches --type rust $'#[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)]' packages/injective-std/src/types/ | while read file; do
# Test: Ensure that the new derive attribute strategy is applied consistently. Expect: Consistent application across all modules.
rg '#[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)]' "$file"
done
Length of output: 174
Script:
#!/bin/bash
# Description: Re-verify the application of new derive attributes across all Rust files in the `types` directory.
# First, list all Rust files in the `types` directory.
find packages/injective-std/src/types/ -type f -name "*.rs" -print
# Then, for each Rust file, check if it contains the specific derive attributes.
while read file; do
echo "Checking file: $file"
rg --count '#[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)]' "$file"
done < <(find packages/injective-std/src/types/ -type f -name "*.rs")
Length of output: 3377
Script:
#!/bin/bash
# Description: Re-verify the application of new derive attributes across all Rust files in the `types` directory using a more robust file handling approach.
# List all Rust files in the `types` directory and check each for the specific derive attributes using xargs for better handling.
find packages/injective-std/src/types/ -type f -name "*.rs" | xargs -I {} sh -c 'echo "Checking file: {}"; rg --count "#[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)]" {}'
Length of output: 4200
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | ||
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
There was a problem hiding this comment.
Tip
Codebase Verification
Several files in the codebase still lack detailed documentation and tests for ConfigResponse:
packages/injective-std/src/types/cosmos/base/node/v1beta1.rs: The structConfigResponseis defined but lacks detailed documentation and specific tests for the fieldminimum_gas_price.
Analysis chain
Consistent changes to derive attributes as seen in other modules. Ensure that the specific fields in ConfigResponse are properly documented and tested.
Also applies to: 10-11
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the specific fields in `ConfigResponse` are properly documented and tested across the project.
# Find all Rust files that use `ConfigResponse` struct from `base/node` module and check for documentation and tests.
rg --files-with-matches --type rust $'use .*::ConfigResponse;' | while read file; do
# Test: Ensure that the specific fields are documented and covered by tests. Expect: Proper documentation and test coverage.
rg 'ConfigResponse::.*{minimum_gas_price}' "$file"
done
Length of output: 75
Script:
#!/bin/bash
# Description: Broaden the search to verify documentation and testing of `ConfigResponse` across the project.
# Find all Rust files that mention `ConfigResponse` and check for any associated documentation and tests.
rg --files-with-matches --type rust 'ConfigResponse' | while read file; do
# Check for any comments or test annotations related to `ConfigResponse`.
rg -C 3 'ConfigResponse' "$file"
done
Length of output: 1489
| #[derive(Clone, PartialEq, Eq, ::prost::Message)] | ||
| #[derive(::serde::Serialize, ::serde::Deserialize, ::schemars::JsonSchema, CosmwasmExt)] |
There was a problem hiding this comment.
Tip
Codebase Verification
Several files in the codebase document the fields max_metadata_len and authority, but no specific tests were found for these fields. It is recommended to add targeted tests to ensure their functionality and reliability.
- Documented in:
packages/injective-std/src/types/injective/tokenfactory/v1beta1.rspackages/injective-std/src/types/injective/wasmx/v1.rspackages/injective-std/src/types/injective/insurance/v1beta1.rspackages/injective-std/src/types/injective/exchange/v1beta1.rspackages/injective-std/src/types/injective/oracle/v1beta1.rspackages/injective-std/src/types/injective/auction/v1beta1.rspackages/injective-std/src/types/cosmwasm/wasm/v1.rspackages/injective-std/src/types/cosmos/staking/v1beta1.rspackages/injective-std/src/types/cosmos/distribution/v1beta1.rspackages/injective-std/src/types/cosmos/gov/module/v1.rspackages/injective-std/src/types/cosmos/distribution/module/v1.rspackages/injective-std/src/types/cosmos/gov/v1.rspackages/injective-std/src/types/cosmos/auth/v1beta1.rspackages/injective-std/src/types/cosmos/auth/module/v1.rspackages/injective-std/src/types/cosmos/bank/v1beta1.rspackages/injective-std/src/types/cosmos/bank/module/v1.rs
Analysis chain
Consistent changes to derive attributes as seen in other modules. Specific fields enhance governance module configuration capabilities. Ensure these fields are properly documented and tested.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the specific fields in `Module` are properly documented and tested across the project.
# Find all Rust files that use `Module` struct from `gov` module and check for documentation and tests.
rg --files-with-matches --type rust $'use .*::Module;' | while read file; do
# Test: Ensure that the specific fields are documented and covered by tests. Expect: Proper documentation and test coverage.
rg 'Module::.*{max_metadata_len, authority}' "$file"
done
Length of output: 67
Script:
#!/bin/bash
# Description: Re-verify the presence and usage of the `Module` struct and its specific fields in the codebase.
# Step 1: Find all Rust files that define or use the `Module` struct.
rg --files-with-matches --type rust 'struct Module' -l
# Step 2: Check for the usage of the specific fields `max_metadata_len` and `authority` in these files.
rg --files-with-matches --type rust 'max_metadata_len|authority' -l
# Step 3: Verify documentation and tests for these fields.
rg --files-with-matches --type rust '///.*max_metadata_len|///.*authority' -l
rg --files-with-matches --type rust '#\[test\].*max_metadata_len|#[test].*authority' -l
Length of output: 2807
Generated bindings from v1.12.10-testnet
Summary by CodeRabbit
New Features
cosmos/feegrantmodule.Documentation
injective-stdREADME with updated commit hashes and specified shell types in code blocks.Refactor
injective-protobuffor improved logical grouping.