Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] PR-55 Fix option --dbt-list doesn't work issue #933

Merged

Conversation

kentwelcome
Copy link
Member

@kentwelcome kentwelcome commented Dec 19, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Bugfix

What this PR does / why we need it:

  • When the user uses run command with option --dbt-list, the list is piped from stdin. (Ex. dbt list -s 'tag:piperider' | pieprider run --dbt-list ). The dbt-list function doesn't work.
  • Before, we only compared the node's unique_id with select dbt resources. However, the format of uniqueId could not be matched with dbt_resource.
    Ex. node['uniuqe_id'] is model.jaffle_shop.stg_customer, dbt_resources['models'] is jaffle_shop.staging.stg_customers
  • In this fix, we will not only compare the unique_id. But also compare the dbt_resources with FQN.

Which issue(s) this PR fixes:
PR-55

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2eb11f7) 48.47% compared to head (e50d5ca) 48.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
+ Coverage   48.47%   48.49%   +0.02%     
==========================================
  Files          63       63              
  Lines        9081     9083       +2     
==========================================
+ Hits         4402     4405       +3     
+ Misses       4679     4678       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentwelcome kentwelcome merged commit e2fdb2c into main Dec 19, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants