Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wrap ruamel yaml library import due to type support #924

Closed

Conversation

wcchang1115
Copy link
Contributor

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • some object types are introduced after ruamel.yaml>=0.17.22, so we add a wrap layer to handle the ImportError.

Which issue(s) this PR fixes:
sc-32539

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #924 (35eee78) into main (02b474b) will decrease coverage by 0.23%.
The diff coverage is 41.17%.

@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
- Coverage   48.48%   48.26%   -0.23%     
==========================================
  Files          63       64       +1     
  Lines        9066     9120      +54     
==========================================
+ Hits         4396     4402       +6     
- Misses       4670     4718      +48     
Files Coverage Δ
piperider_cli/__init__.py 51.75% <50.00%> (-0.29%) ⬇️
piperider_cli/dbtutil.py 66.72% <50.00%> (-0.19%) ⬇️
piperider_cli/event/__init__.py 78.57% <50.00%> (-1.25%) ⬇️
piperider_cli/initializer.py 45.91% <50.00%> (-0.25%) ⬇️
piperider_cli/recipes/__init__.py 23.69% <50.00%> (+0.06%) ⬆️
piperider_cli/configuration.py 59.65% <50.00%> (-0.26%) ⬇️
piperider_cli/yaml/yaml_rich_type/__init__.py 74.35% <74.35%> (ø)
piperider_cli/yaml/yaml_less_type/__init__.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@wcchang1115 wcchang1115 force-pushed the bug/sc-32539/incorrect-ruamel-import-in-init-py branch from a48b1ea to 35eee78 Compare November 7, 2023 03:44
@wcchang1115 wcchang1115 marked this pull request as ready for review November 7, 2023 03:58
@qrtt1 qrtt1 self-requested a review November 7, 2023 08:56
Copy link
Contributor

@qrtt1 qrtt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be replaced by #925

@wcchang1115 wcchang1115 closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants