Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Remove assertion feature #917

Merged

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Oct 25, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
chore

What this PR does / why we need it:

  • piperider assertion is a deprecated feature, and we are going to remove it from the code base.

Which issue(s) this PR fixes:
sc-32471

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #917 (ce67823) into main (04e6a2e) will increase coverage by 0.50%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   47.99%   48.49%   +0.50%     
==========================================
  Files          78       63      -15     
  Lines       10756     9064    -1692     
==========================================
- Hits         5162     4396     -766     
+ Misses       5594     4668     -926     
Files Coverage Δ
piperider_cli/cli.py 68.83% <ø> (+1.23%) ⬆️
piperider_cli/cli_utils/run_cmd.py 92.55% <ø> (ø)
piperider_cli/event/events.py 91.30% <ø> (-1.56%) ⬇️
piperider_cli/validator.py 23.52% <ø> (+1.30%) ⬆️
piperider_cli/runner.py 62.40% <62.50%> (+8.80%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcchang1115 wcchang1115 marked this pull request as ready for review October 26, 2023 07:47
Copy link
Member

@kentwelcome kentwelcome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcchang1115 wcchang1115 merged commit ed06cf9 into main Oct 30, 2023
31 checks passed
@wcchang1115 wcchang1115 deleted the feature/sc-32471/help-piperider-lose-weight-remove-assertion branch October 30, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants