Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Add handler for server side error response when uploading report #915

Merged

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Oct 24, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • add error handler when a response can not be decoded in json format.

Which issue(s) this PR fixes:
sc-32458

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #915 (888c28b) into main (c35b2b7) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   48.00%   48.00%   -0.01%     
==========================================
  Files          78       78              
  Lines       10751    10756       +5     
==========================================
+ Hits         5161     5163       +2     
- Misses       5590     5593       +3     
Files Coverage Δ
piperider_cli/cloud/__init__.py 25.08% <16.66%> (-0.09%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcchang1115 wcchang1115 changed the title [Bug] Add handler for server side error response [Bug] Add handler for server side error response when uploading report Oct 24, 2023
@wcchang1115 wcchang1115 marked this pull request as ready for review October 25, 2023 02:17
@wcchang1115 wcchang1115 merged commit 04e6a2e into main Oct 25, 2023
31 of 32 checks passed
@wcchang1115 wcchang1115 deleted the bug/sc-32458/jsondecodeerror-expecting-value-line-1-column branch October 25, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants