Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Add a handler to unexpected json file format #904

Merged

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Oct 18, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • add a handler when loading a broken json file

Which issue(s) this PR fixes:
sc-32380

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

wcchang1115 and others added 2 commits October 17, 2023 19:02
Signed-off-by: Wei-Chun, Chang <[email protected]>
Co-authored-by: Ching Yi, Chan <[email protected]>
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #904 (c9ee12d) into main (106b730) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 82.35%.

@@           Coverage Diff           @@
##             main     #904   +/-   ##
=======================================
  Coverage   48.02%   48.02%           
=======================================
  Files          77       77           
  Lines       10685    10690    +5     
=======================================
+ Hits         5131     5134    +3     
- Misses       5554     5556    +2     
Files Coverage Δ
piperider_cli/event/collector.py 87.20% <82.35%> (-3.27%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcchang1115 wcchang1115 marked this pull request as ready for review October 18, 2023 04:14
@wcchang1115 wcchang1115 requested a review from qrtt1 October 18, 2023 06:19
Copy link
Contributor

@qrtt1 qrtt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcchang1115 wcchang1115 merged commit 2e7f921 into main Oct 18, 2023
31 checks passed
@kentwelcome kentwelcome deleted the bug/sc-32380/jsondecodeerror-expecting-value-line-1-column branch October 18, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants