Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Skip passing dbt resources when compare with custom recipe #902

Conversation

wcchang1115
Copy link
Contributor

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • compare with a recipe will provide dbt resources for further profiling.
  • it should not affect the profiler when user defines their own recipe.

Which issue(s) this PR fixes:
sc-32418

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #902 (0c4b645) into main (a1a9823) will decrease coverage by 0.19%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   48.20%   48.01%   -0.19%     
==========================================
  Files          76       77       +1     
  Lines       10645    10688      +43     
==========================================
+ Hits         5131     5132       +1     
- Misses       5514     5556      +42     
Files Coverage Δ
piperider_cli/recipes/__init__.py 23.79% <0.00%> (-0.16%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcchang1115 wcchang1115 marked this pull request as ready for review October 18, 2023 02:02
Copy link
Member

@kentwelcome kentwelcome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentwelcome kentwelcome merged commit 75d3fda into main Oct 18, 2023
29 of 30 checks passed
@kentwelcome kentwelcome deleted the bug/sc-32418/bug-piperider-profiling-all-models-when-given-set-of-models branch October 18, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants