Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Failed to read yaml file in concurrent #901

Merged

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Oct 17, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • profiler would load user profile when an exception happens, and we need to make load_user_profile thread safe.

Which issue(s) this PR fixes:
sc-32407

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #901 (325567c) into main (a1a9823) will increase coverage by 0.02%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
+ Coverage   48.20%   48.22%   +0.02%     
==========================================
  Files          76       76              
  Lines       10645    10648       +3     
==========================================
+ Hits         5131     5135       +4     
+ Misses       5514     5513       -1     
Files Coverage Δ
piperider_cli/event/__init__.py 80.00% <90.00%> (+0.56%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcchang1115 wcchang1115 marked this pull request as ready for review October 17, 2023 07:45
@wcchang1115 wcchang1115 changed the title [Bug] Read yaml file with separate yaml instance [Bug] Failed to read yaml file in concurrent Oct 17, 2023
@popcornylu popcornylu merged commit 5efa1ea into main Oct 18, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants