feat: create statistics page #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pj-cegeka
force-pushed
the
feat/statistics
branch
from
a622128 to
ed739e1
Compare
pj-cegeka
requested review from
Yalz,
rorlic,
WLefever-Cegeka,
Tomvbe and
jobulcke
as code owners
Yalz
approved these changes
Oct 4, 2023
Comment on lines
+23
to
+24
| "ingested member count": 4018, | ||
| "current member count": 4018, |
There was a problem hiding this comment.
Frankly, to an outsider, this might be quite confusing..
The difference between Ingested members and current member count is only something for internal purposes, no?
There was a problem hiding this comment.
True, ingested might be beter as historical member count? or something like that
| | http://test-data/mobility-hindrance/1/2 | mobility-hindrances | 12 | http://test-data/mobility-hindrance/1 | | ||
| | http://test-data/mobility-hindrance/1/3 | mobility-hindrances | 3 | http://test-data/mobility-hindrance/1 | | ||
| When I save the members using the MemberRepository | ||
| And I search for the first member from collection "mobility-hindrances" and sequenceNr greater than -1 |
There was a problem hiding this comment.
Ok you're looking for sequence nr 0 ? why not do greater than or equals? because this feels strange?
There was a problem hiding this comment.
This actually isn't my test, the formatting on it was just weird so i fixed that. So i'm not sure if there is a purpose for it.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.