* fix convertCurrency mock

* remove redundant checks for type and NaN from `convertBidFloorCurrency` function
ImproveDigital · Oct 11, 2024 · 9e0a49c · 9e0a49c
1 parent 17f3fa6
commit 9e0a49c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/modules/improvedigitalBidAdapter.js b/modules/improvedigitalBidAdapter.js
@@ -134,10 +134,8 @@ const convertBidFloorCurrency = (imp) => {
       DEFAULT_CURRENCY,
       false,
     );
-    if (typeof bidFloor === 'number' && !isNaN(bidFloor)) {
-      imp.bidfloor = bidFloor;
-      imp.bidfloorcur = DEFAULT_CURRENCY;
-    }
+    imp.bidfloor = bidFloor;
+    imp.bidfloorcur = DEFAULT_CURRENCY;
   } catch (err) {
     logWarn(`Failed to convert bid floor to ${DEFAULT_CURRENCY}. Passing floor price in its original currency.`, err);
   }

diff --git a/test/spec/modules/improvedigitalBidAdapter_spec.js b/test/spec/modules/improvedigitalBidAdapter_spec.js
@@ -360,7 +360,11 @@ describe('Improve Digital Adapter Tests', function () {
       getGlobalStub = sinon.stub(prebidGlobal, 'getGlobal').returns({
         convertCurrency: (cpm, from, to) => {
           const conversionKeys = { 'EUR-USD': 1.75 };
-          return cpm * conversionKeys[`${from}-${to}`];
+          const conversionRate = conversionKeys[`${from}-${to}`];
+          if (!conversionRate) {
+            throw new Error(`No conversion rate found for ${from}-${to}`);
+          }
+          return cpm * conversionRate;
         }
       });
       const bidRequest = deepClone(simpleBidRequest);