Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop branch with main #284

Merged
merged 67 commits into from
May 3, 2024
Merged

Update develop branch with main #284

merged 67 commits into from
May 3, 2024

Conversation

ben-l-p
Copy link
Collaborator

@ben-l-p ben-l-p commented Apr 1, 2024

Updating develop branch with the main branch. This includes the new pip installation method, as well as some other small fixes.

ACea15 and others added 30 commits May 31, 2023 14:26
- fix intend otherwise these linear/rom systems would only be saved if no data.h5 file exist from the start
- remove all files before it is written as overwriting them causes an Assertation error
In the previous version, less modes are extracted for free flying aircraft because number of rigid body DoFs are wrongly substracted from the total number of modes although the first modes (which are the rigid body modes) are already skipped. Thus if 30 modes are to be exported only 10 mode shapes are created.
Update XBeam version to include compiler optimisation
- caused error in opening the jupyter notebook and for the  tutorial not to be displayed in the readthedocs documentation
- before it creates an output file with extra columns without any values
NoAero errors out because of missing optional input - fixed
Update noaero.py for consistency in function input
Also fixed an issue with SHARPy not running due to a package import error.
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 60.71429% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 67.70%. Comparing base (4b5a520) to head (8bd0eba).
Report is 34 commits behind head on develop.

Files Patch % Lines
sharpy/postproc/savedata.py 52.17% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #284   +/-   ##
========================================
  Coverage    67.69%   67.70%           
========================================
  Files          166      166           
  Lines        26709    26710    +1     
========================================
+ Hits         18081    18083    +2     
+ Misses        8628     8627    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kccwing and others added 2 commits April 18, 2024 12:23
Copy link
Collaborator

@kccwing kccwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ben-l-p, @sduess!!

@kccwing kccwing merged commit d16e60a into develop May 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants