Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added environment for Apple Silicon (ARM64) #254

Merged
merged 16 commits into from
Oct 18, 2023
Merged

Added environment for Apple Silicon (ARM64) #254

merged 16 commits into from
Oct 18, 2023

Conversation

ben-l-p
Copy link
Collaborator

@ben-l-p ben-l-p commented Oct 4, 2023 •
edited
Loading

Added environment for Apple Silicon (ARM64)

@ben-l-p ben-l-p closed this Oct 4, 2023
@ben-l-p ben-l-p reopened this Oct 4, 2023
@ben-l-p ben-l-p changed the title Add files via upload Added environment for Apple Silicon (ARM64) Oct 4, 2023
@kccwing kccwing self-requested a review October 4, 2023 15:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #254 (3ef2997) into develop (362cd33) will increase coverage by 0.48%.
Report is 279 commits behind head on develop.
The diff coverage is 86.16%.

@@             Coverage Diff             @@
##           develop     #254      +/-   ##
===========================================
+ Coverage    67.20%   67.69%   +0.48%     
===========================================
  Files          156      166      +10     
  Lines        25924    26709     +785     
===========================================
+ Hits         17423    18081     +658     
- Misses        8501     8628     +127
Files Coverage Δ
sharpy/aero/utils/mapping.py 100.00% <100.00%> (ø)
sharpy/cases/templates/flying_wings.py 89.92% <100.00%> (-0.02%) ⬇️
.../templates/fuselage_wing_configuration/__init__.py 100.00% <ø> (ø)
...rpy/linear/assembler/lincontrolsurfacedeflector.py 85.18% <100.00%> (ø)
sharpy/linear/assembler/linearaeroelastic.py 86.54% <100.00%> (ø)
sharpy/linear/assembler/linearuvlm.py 93.30% <100.00%> (ø)
sharpy/postproc/liftdistribution.py 100.00% <100.00%> (+57.14%) ⬆️
sharpy/solvers/aerogridloader.py 100.00% <100.00%> (ø)
sharpy/solvers/nonliftingbodygridloader.py 100.00% <100.00%> (ø)
sharpy/solvers/nonlineardynamiccoupledstep.py 94.91% <ø> (-0.09%) ⬇️
... and 29 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ben-l-p added 14 commits October 9, 2023 10:08
@ben-l-p
Update environment_macos_arm64.yml
a736861 
Replaced environment file to use the new environment. Only change is the less strict make version requirement.
@ben-l-p
Update installation instructions
aa87195
@ben-l-p
Delete utils/environment_macos.yml
1211514 
Old MacOS environment is to be replaced with the new environment
@ben-l-p
Changed make version from 3.14 to 3.19 (Apple Silicon minimum)
9441349
@ben-l-p
Finalised install guide changes for new environment
6bf9a58
@ben-l-p
Delete utils/environment_macos_arm64.yml
f85e81b 
Environment not needed - replaced with environment_new.yml
@ben-l-p
Delete utils/environment_linux.yml
bb60716
@ben-l-p
Delete utils/environment_minimal.yml
0440646
@ben-l-p
Rename environment_new.yml to environment.yml
0493bfd
@ben-l-p
Update bashrc to not use minimal environment
aace787
@ben-l-p
Renamed environment file in documentation
d1760e2
@ben-l-p
Update Dockerfile to use renamed environment
2995b06
@ben-l-p
Update sharpy_tests.yaml to use renamed environment
5034646
@ben-l-p
Update contributing.md to use renamed environment
0b343d8
kccwing
kccwing approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@kccwing kccwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ben-l-p - good first contribution! Looking forward to the nice things to come :)

@kccwing kccwing merged commit f0b68a2 into develop Oct 18, 2023
5 checks passed
@kccwing kccwing deleted the dev_arm64 branch October 18, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kccwing kccwing kccwing approved these changes

Assignees

@ben-l-p ben-l-p

Labels
enhancement good first contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ben-l-p @codecov-commenter @kccwing