Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated T Model module #370

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

davidorme
Copy link
Collaborator

Description

This PR:

  • Removes pyrealm.tmodel and associated docs and links. This functionality has been reimplemented in the demography module.
  • Moves pyrealm.demography.t_model_functions to pyrealm.demography.tmodel, to shorten the namespace, now that there isn't the old module to get confused with.

Fixes #368

Type of change

None of the below - deprecating old functionality.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@davidorme davidorme linked an issue Dec 12, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (1f315ba) to head (f9ffb7c).
Report is 512 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #370      +/-   ##
===========================================
+ Coverage    95.29%   96.26%   +0.97%     
===========================================
  Files           28       34       +6     
  Lines         1720     2652     +932     
===========================================
+ Hits          1639     2553     +914     
- Misses          81       99      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MarionBWeinzierl MarionBWeinzierl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look sensible to me. Also good to update the docs index files with the splash model etc.

@davidorme davidorme merged commit c096806 into develop Dec 12, 2024
13 checks passed
@davidorme davidorme deleted the 368-remove-outdated-t-model-module branch December 12, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove outdated T Model module.
3 participants