Updating mypy in poetry to version 1 #365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates
mypy
inpoetry
to match the version now being used inpre-commit
- I was getting errors frompre-commit
that weren't being shown in VSCode, because it uses the setup in thepoetry
environment.The initial PR was also updating
numpy
to2.2.0
and that turns out to be a problem because of a change in the handling of typing numpy floating arrays:numpy/numpy#27957
This still seems a bit lively, so this PR:
pyproject.toml
to specifymypy: "^1.0.0"
to keep up withpre-commit
.It also pins
numpy
in two places to<2.2
pyproject.toml
sets~2.1
.pre-commit-config.yaml
specifiesnumpy==2.1.3
as amypy
dependency.We'll need to unpin those at some point, but let's see how that
numpy
issue resolves.Fixes #384 (issue)
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks