Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding regression test data for phenology #360

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

davidorme
Copy link
Collaborator

@davidorme davidorme commented Dec 4, 2024

This PR adds the regression test and development data for the phenology module to the pyrealm_build_data module. It provides three data files:

  • pyrealm_build_data/phenology/FLX_DE-Gri_FLUXNET2015_phenology_inputs.csv: A 10 year time series of half hourly FluxNET inputs used to calculate potential GPP using the Subdaily P Model for the phenology calculations.
  • pyrealm_build_data/phenology/DE_Gri_Grassland_example_subset.csv: A 10 year time series of daily data calculated from the half hourly inputs and then predictions of daily phenological variables.
  • pyrealm_build_data/phenology/DE-GRI_site_data.json: Constant site data including coordinates, elevation and site constants for aridity and other phenological calculation constants.

These are a bit bulky (40 MB in total) but the demonstration implementation from @zhouboya uses a long period. We might want to cut it down later, but this is source package only data.

Fixes #354

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (1f315ba) to head (318dbf7).
Report is 500 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #360      +/-   ##
===========================================
+ Coverage    95.29%   96.09%   +0.80%     
===========================================
  Files           28       35       +7     
  Lines         1720     2766    +1046     
===========================================
+ Hits          1639     2658    +1019     
- Misses          81      108      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@j-emberton j-emberton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine and I'm happy to approve.

@davidorme davidorme merged commit fdda17c into develop Dec 4, 2024
13 checks passed
@davidorme davidorme deleted the 354-create-a-phenology-golden-dataset branch December 4, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create a golden dataset for use in testing and development of phenology module
3 participants