Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to work on issue #352, providing code to identify the growing season within a time series. The user should provide a logical array showing a daily time series of when conditions are suitable for growth, along with an array showing dates (align with solar/calendar stuff) and then this module provides tools to calculate the start, end and length of the growing season. The functionality should include a filter to remove short windows of unsuitable conditions.
filter_short_intervals
to remove short intervals of unsuitable conditions. This should probably not filter unsuitable conditions at the start and end of the time series (or do so optionally).growing_season(ts, dates, filter_unsuitable)
.Fixes #352 (issue)
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks