-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete implementation of T model functions #285
Complete implementation of T model functions #285
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #285 +/- ##
===========================================
- Coverage 95.29% 95.17% -0.12%
===========================================
Files 28 32 +4
Lines 1720 2093 +373
===========================================
+ Hits 1639 1992 +353
- Misses 81 101 +20 ☔ View full report in Codecov by Sentry. |
When putting in assertions, would it make sense to set a tolerance for |
These ones are purely deterministic and should be precise - or at least to the high default tolerance of |
.. math:: | ||
P_{net} = y (P - R_m) = y (P - W_{\cdot s} r_s - \zeta \sigma W_f r_r - P r_f) | ||
|
||
Note that this differs from Equation 13 of :cite:t:`Li:2014bc`, which removes foliar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a citation for this approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - it's a "new" approach but only in the pretty trivial sense that the foliage respiration rate can be tuned. I'll clarify that.
Looks fine to me aside from the queries on citations. Happy to approve and let you update the docstrings as you wish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR:
demography
module. It is basically unpacking the currentpyrealm.tmodel.TModel.calculate_growth
method for estimating growth increments into standalone functions with proper docstrings etc. following @AmyOctoCat 's similar treatment ofpyrealm.tmodel.TModel.reset_diameters
for the allometric scaling.rtmodel.r
implementation to include predictions from more than one plant functional type.pyrealm.demography.t_model_functions
against those new regression golden outputs.Does not add any user-facing documentation yet.
Fixes #284
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks