Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing PR checkers hanging after profiling runs on PR approval #242

Closed

Conversation

AmyOctoCat
Copy link
Collaborator

@AmyOctoCat AmyOctoCat commented May 24, 2024

Description

Attempting to fix the issue of the PR checkers hanging in a 'Waiting' state after approval. Currently the profiling is auto-generating a commit on approval with a commit message that contains [skip actions]. Trying to remove this to see if it fixes the issue, although I am unsure if github will allow a commit generated by an action to trigger further actions. Need approval to see if the fix has worked.

Fixes #241

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a - N/A
  • All tests pass: $ poetry run pytest - N/A

Further checks

  • Code is commented, particularly in hard-to-understand areas - N/A
  • Tests added that prove fix is effective or that feature works - N/A

@AmyOctoCat AmyOctoCat linked an issue May 24, 2024 that may be closed by this pull request
@davidorme
Copy link
Collaborator

LGTM! The intention of that was to simply skip those checks, but clearly not working as intended.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (290938a) to head (2aa5a4c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #242   +/-   ##
========================================
  Coverage    95.23%   95.23%           
========================================
  Files           28       28           
  Lines         1701     1701           
========================================
  Hits          1620     1620           
  Misses          81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmyOctoCat
Copy link
Collaborator Author

Thanks for the approval @davidorme . It looks like it hadn't fixed it as I'd hoped unfortunately. I think it might still be the issue of the commit being generated by another action unfortunately, which might be a bit harder to work around...

@MarionBWeinzierl
Copy link
Collaborator

MarionBWeinzierl commented Jul 4, 2024

I opened #256 - GH are disabled atm, manual profiling should be done

@davidorme davidorme deleted the 241-pr-checker-github-actions-hanging-after-approval branch October 16, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

PR Checker Github actions hanging after approval
4 participants