Skip to content

Commit

Permalink
correct memory_effect to use correct dimensional array assignments
Browse files Browse the repository at this point in the history
  • Loading branch information
MarionBWeinzierl committed Oct 2, 2024
1 parent 2b9d02f commit 3f48d92
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions pyrealm/pmodel/subdaily.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def memory_effect(
if initial_values is None:
memory_values[0] = values[0]
else:
memory_values[0] = initial_values
memory_values[0] = initial_values[0]

# Handle the data if there are no missing data,
if not nan_present:
Expand Down Expand Up @@ -408,20 +408,23 @@ def __init__(
# 5) Calculate the realised daily values from the instantaneous optimal values
self.xi_real: NDArray = memory_effect(
self.pmodel_acclim.optchi.xi,
init_xi_real,
initial_values=init_xi_real,
alpha=alpha,
allow_holdover=allow_holdover,
)
r"""Realised daily slow responses in :math:`\xi`"""
self.vcmax25_real: NDArray = memory_effect(
self.vcmax25_opt,
init_vcmax_real,
initial_values=init_vcmax_real,
alpha=alpha,
allow_holdover=allow_holdover,
)
r"""Realised daily slow responses in :math:`V_{cmax25}`"""
self.jmax25_real: NDArray = memory_effect(
self.jmax25_opt, init_jmax_real, alpha=alpha, allow_holdover=allow_holdover
self.jmax25_opt,
initial_values=init_jmax_real,
alpha=alpha,
allow_holdover=allow_holdover,
)

r"""Realised daily slow responses in :math:`J_{max25}`"""
Expand Down

0 comments on commit 3f48d92

Please sign in to comment.