Add fields to OpalModel #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianDAlessandro
force-pushed
the
opal-changes
branch
from
f733ede to
0766757
Compare
AdrianDAlessandro
force-pushed
the
opal-changes
branch
from
0766757 to
2fef976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some fields to the
OpalModelso that they can be received and plotted. It also removed the pre-set values of 0 at the 0-index and ensures the datatypes in the data frames remain consistent.This PR also makes it easier to add new fields to Opal without needing to change the rest of the code and tests. (ie, removes a lot of hard-coded values).
@yuezhu71 can you confirm these new fields make sense and you will be able to send them?
Close #182
Close #185