Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logged in user as default creator in submission form #90

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

J4bbi
Copy link
Collaborator

@J4bbi J4bbi commented Nov 25, 2024


This PR introduces an utility function for the settings module that formats user profile information to
become a creator default value in the submission form.

It presupposes that a user will always be a person, and not an organisation.

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section can be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run

@J4bbi J4bbi requested a review from cc-a November 25, 2024 12:26
@J4bbi J4bbi force-pushed the feature/depositing_user_as_creator branch from c3f964c to ce1d872 Compare November 25, 2024 12:34
Copy link
Collaborator

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a couple of minor tweaks suggested. Let's merge and open an issue to track a potential improvement down the line once we are better integrated with ICL data sources that would enable us to provide more comprehensive information.

site/ic_data_repo/config/utils.py Outdated Show resolved Hide resolved
@J4bbi J4bbi requested a review from cc-a December 9, 2024 10:27
@cc-a cc-a force-pushed the feature/depositing_user_as_creator branch from 52c82f1 to 0971f69 Compare December 9, 2024 15:57
@cc-a cc-a enabled auto-merge December 9, 2024 15:57
@cc-a cc-a merged commit 0dcece3 into develop Dec 9, 2024
2 checks passed
@cc-a cc-a deleted the feature/depositing_user_as_creator branch December 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants