Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hide set defaults #87

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Feature/hide set defaults #87

merged 4 commits into from
Nov 19, 2024

Conversation

J4bbi
Copy link
Collaborator

@J4bbi J4bbi commented Nov 12, 2024


This PR hides the input controls for three fields and sets default values for them in the config.

TODO
An enclosing div is still rendered in the form. A horizontal gray line.

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section can be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run

@J4bbi J4bbi force-pushed the feature/hide_set_defaults branch from 0498b70 to d9f0532 Compare November 12, 2024 13:56
@J4bbi J4bbi marked this pull request as ready for review November 13, 2024 16:57
@cc-a cc-a self-requested a review November 19, 2024 14:07
Copy link
Collaborator

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @J4bbi, looks good to me.

A thought occurred to me about the publication date field. We've decided to hide it but there is still going to be a value set (presumably the date when the draft is initially created). As I understand it Invenio's publication date field maps to publicationYear of the datacite schema. There is some specific guidance in the Datacite schema that:

If an embargo period has been in effect, use the date when the embargo period ends. In the case of datasets, “publish” is understood to mean making the data available on a specific date to the community of researchers.

This still doesn't feel like a value that the end user should be controlling so I don't think this affects our decision to hide the field but it might make sense for the value to determined more dynamically than just when the initial version of the draft is created. I'm going to create a new issue to track investigation into the current interaction with the Datacite schema but this is not something I anticipate being a priority in the near future.

@cc-a cc-a enabled auto-merge November 19, 2024 22:34
@cc-a cc-a merged commit e8ac30f into develop Nov 19, 2024
2 checks passed
@cc-a cc-a deleted the feature/hide_set_defaults branch November 19, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants