Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try creating drafts until it happens #65

Closed
wants to merge 1 commit into from
Closed

Conversation

J4bbi
Copy link
Collaborator

@J4bbi J4bbi commented Aug 27, 2024

When Helm initial deployment is made importing fixtures can take several minutes and is done asynchronously through celery workers. There is no elegant way to poll Invenio to know when the import has finished and therefore trying to create the drafts until they succeed is the best approach.

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section can be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run

@J4bbi J4bbi requested a review from cc-a August 27, 2024 08:49
Copy link
Collaborator

@Steven-Eardley Steven-Eardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, keep knocking on the door until someone lets you in

@J4bbi J4bbi closed this Aug 27, 2024
@J4bbi J4bbi reopened this Aug 27, 2024
@cc-a
Copy link
Collaborator

cc-a commented Oct 28, 2024

I believe this is no longer required @J4bbi?

@J4bbi J4bbi closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants