Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the tree table page #262

Merged
merged 17 commits into from
Dec 10, 2024
Merged

Adds the tree table page #262

merged 17 commits into from
Dec 10, 2024

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Dec 5, 2024

Description

Adds the tree table page, giving more detail on the host and detector associated with each application.

  • Implement getting the detector from the backend, when available.

Fixes #229
Fixes #167
Fixes #230 (umbrella)
Fixes #164 (umbrella of the umbrella)

Recording.2024-12-05.062753.mp4

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.49%. Comparing base (f709b45) to head (12a1f53).

Files with missing lines Patch % Lines
process_manager/process_manager_interface.py 16.66% 5 Missing ⚠️
controller/views/partials.py 60.00% 2 Missing ⚠️
controller/views/pages.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             tree     #262      +/-   ##
==========================================
- Coverage   86.73%   86.49%   -0.25%     
==========================================
  Files          38       39       +1     
  Lines         558      607      +49     
==========================================
+ Hits          484      525      +41     
- Misses         74       82       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was linked to issues Dec 5, 2024
@dalonsoa dalonsoa removed a link to an issue Dec 5, 2024
2 tasks
Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Some generic comments.

Is there a testy for the AppTreeTable?

controller/controller_interface.py Outdated Show resolved Hide resolved
controller/controller_interface.py Show resolved Hide resolved
controller/controller_interface.py Show resolved Hide resolved
tests/controller/test_app_tree.py Show resolved Hide resolved
Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

A few minor things and a couple of questions.

drunc_ui/settings/settings.py Show resolved Hide resolved
controller/templates/controller/index.html Show resolved Hide resolved
controller/app_tree.py Outdated Show resolved Hide resolved
controller/controller_interface.py Show resolved Hide resolved
@jamesturner246 jamesturner246 self-requested a review December 9, 2024 16:26
Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't block for such a small thing, but see last review.

@cc-a cc-a merged commit 18704e4 into tree Dec 10, 2024
4 checks passed
@cc-a cc-a deleted the tree-table branch December 10, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants