-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the tree table page #262
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## tree #262 +/- ##
==========================================
- Coverage 86.73% 86.49% -0.25%
==========================================
Files 38 39 +1
Lines 558 607 +49
==========================================
+ Hits 484 525 +41
- Misses 74 82 +8 ☔ View full report in Codecov by Sentry. |
Use 1x1 config as default session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good! Some generic comments.
Is there a testy for the AppTreeTable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 👍
A few minor things and a couple of questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't block for such a small thing, but see last review.
Description
Adds the tree table page, giving more detail on the host and detector associated with each application.
Fixes #229
Fixes #167
Fixes #230 (umbrella)
Fixes #164 (umbrella of the umbrella)
Recording.2024-12-05.062753.mp4
Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks