Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs #246

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Docs #246

merged 12 commits into from
Dec 5, 2024

Conversation

cc-a
Copy link
Contributor

@cc-a cc-a commented Nov 27, 2024

Description

This PR adds developer documentation for the project. As I'm looking to step back from leading the project this is a great time to ask any questions you may have about Dune or the development setup or just about anything so we can record it now.

Fixes: #210 #211 #212 #173

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

# Conflicts:
#	README.md
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.84%. Comparing base (41de11f) to head (db3b973).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   83.33%   82.84%   -0.50%     
==========================================
  Files          34       33       -1     
  Lines         432      408      -24     
==========================================
- Hits          360      338      -22     
+ Misses         72       70       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of comments, but looks great to me.

Certainly part of a different PRs, but I think it would be valuable at some point to describe in detail the Dockerfiles and the docker-compose file. Much (all?) of what this tool does - at least in development - depends on the docker setup, so a good understanding on what's going on there would be useful.

docs/code_overview.md Outdated Show resolved Hide resolved
docs/code_overview.md Outdated Show resolved Hide resolved
docs/code_overview.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@cc-a
Copy link
Contributor Author

cc-a commented Nov 29, 2024

Sounds good @dalonsoa. I've made #251 to track.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm not sure what's missing, but what is there works. I've made a comment about removing detail from the readme. Hopefully my suggestion can help get the setup instructions back into there.

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the Mac note @AdrianDAlessandro mentioned, LGTM. 👍

I can't think of anything else required to get going offhand. My only questions really were about when and where we should be accessing drunc directly for debugging, but that will be covered in #249, I guess.

@cc-a cc-a enabled auto-merge December 5, 2024 14:52
@cc-a cc-a merged commit 2acfbf0 into main Dec 5, 2024
4 checks passed
@cc-a cc-a deleted the docs branch December 5, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants