-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs #246
Conversation
# Conflicts: # README.md
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 83.33% 82.84% -0.50%
==========================================
Files 34 33 -1
Lines 432 408 -24
==========================================
- Hits 360 338 -22
+ Misses 72 70 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a couple of comments, but looks great to me.
Certainly part of a different PRs, but I think it would be valuable at some point to describe in detail the Dockerfiles and the docker-compose file. Much (all?) of what this tool does - at least in development - depends on the docker setup, so a good understanding on what's going on there would be useful.
Co-authored-by: Diego Alonso Álvarez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I'm not sure what's missing, but what is there works. I've made a comment about removing detail from the readme. Hopefully my suggestion can help get the setup instructions back into there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the Mac note @AdrianDAlessandro mentioned, LGTM. 👍
I can't think of anything else required to get going offhand. My only questions really were about when and where we should be accessing drunc directly for debugging, but that will be covered in #249, I guess.
Description
This PR adds developer documentation for the project. As I'm looking to step back from leading the project this is a great time to ask any questions you may have about Dune or the development setup or just about anything so we can record it now.
Fixes: #210 #211 #212 #173
Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks