Use web app user in logs and process management #208
Conversation
TinyMarsh
requested review from
dalonsoa,
jamesturner246,
cc-a,
alexdewar,
AdrianDAlessandro and
Sahil590
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage ? 82.00%
=======================================
Files ? 31
Lines ? 400
Branches ? 0
=======================================
Hits ? 328
Misses ? 72
Partials ? 0 ☔ View full report in Codecov by Sentry. |
| @@ -57,5 +57,5 @@ def form_valid(self, form: BootProcessForm) -> HttpResponse: | |||
| Returns: | |||
| A redirect to the index page. | |||
| """ | |||
| boot_process("root", form.cleaned_data) | |||
There was a problem hiding this comment.
See above comment on the boot_process function.
|
|
||
|
|
||
| async def _boot_process(user: str, data: dict[str, str | int]) -> None: | ||
| pmd = get_process_manager_driver() | ||
| pmd = get_process_manager_driver(user) | ||
| async for item in pmd.dummy_boot(user=user, **data): |
There was a problem hiding this comment.
One catch is that for any of the dummy processes to run in our docker setup they need to be owned by root, i.e. the user argument to pmd.dummy_boot needs to be "root". This is something I need to document properly in #107. We still want the Django user to be named in the kafka messages however so let's move the hard coding of "root" into this function. The hard-coding is ok as this dummy boot function is only a nicety for development (something else we need to document).
| """Get a ProcessManagerDriver instance.""" | ||
| token = create_dummy_token_from_uname() | ||
| token = Token(token=f"{username}-token", user_name=username) |
There was a problem hiding this comment.
Assuming this actually works with their authentication system
There was a problem hiding this comment.
For the moment they're using a DummyAuthoriser that doesn't check the token.
Description
This PR adresses #111 by passing the web app username - from the
requestobject available in views - to function signatures where the username is relevant to the function i.e. logs and process management.Fixes #111
Type of change
Key checklist
python -m pytest)python -m sphinx -b html docs docs/build)pre-commit run --all-files)Further checks