Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorters search #207

Merged
merged 70 commits into from
Dec 4, 2024
Merged

Sorters search #207

merged 70 commits into from
Dec 4, 2024

Conversation

cvzbynek
Copy link
Collaborator

@cvzbynek cvzbynek commented Nov 5, 2024

Description

This PR introduces sorting capabilities for each column and an advanced search bar, enhancing the table's interactivity and search precision. The updates address the following key improvements:

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (e.g., python -m pytest)
  • The documentation builds and looks OK (e.g., python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (e.g., pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future

cvzbynek and others added 26 commits October 31, 2024 15:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.33%. Comparing base (3969717) to head (0208262).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   83.63%   83.33%   -0.31%     
==========================================
  Files          34       34              
  Lines         440      432       -8     
==========================================
- Hits          368      360       -8     
  Misses         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cvzbynek
Copy link
Collaborator Author

@cc-a @dalonsoa
The JavaScript has been transcribed to Hyperscript, and there are no errors appearing in the console.

@cvzbynek cvzbynek requested a review from cc-a November 21, 2024 12:25
Copy link
Contributor

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes fixed the race condition for me.

@cc-a cc-a enabled auto-merge November 29, 2024 17:00
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cc-a cc-a merged commit 7fd7c95 into main Dec 4, 2024
4 checks passed
@cc-a cc-a deleted the Sorters_search branch December 4, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants