-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package to FunctionReference #69
Open
dalonsoa
wants to merge
3
commits into
develop
Choose a base branch
from
package_info
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
from r2t2 import add_reference | ||
|
||
|
||
@add_reference(short_purpose="Original implementation of R2T2", | ||
reference="Diego Alonso-Álvarez, et al." | ||
"(2018, February 27). Solcore (Version 5.1.0). Zenodo." | ||
"http://doi.org/10.5281/zenodo.1185316") | ||
class MyGreatClass(): | ||
@add_reference( | ||
short_purpose="Original implementation of R2T2", | ||
reference="Diego Alonso-Álvarez, et al." | ||
"(2018, February 27). Solcore (Version 5.1.0). Zenodo." | ||
"http://doi.org/10.5281/zenodo.1185316", | ||
) | ||
class MyGreatClass: | ||
pass |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,12 @@ | ||
from r2t2 import add_reference | ||
|
||
|
||
class MyGreatClass(): | ||
|
||
@add_reference(short_purpose="Original implementation of R2T2", | ||
reference="Diego Alonso-Álvarez, et al." | ||
"(2018, February 27). Solcore (Version 5.1.0). Zenodo." | ||
"http://doi.org/10.5281/zenodo.1185316") | ||
class MyGreatClass: | ||
@add_reference( | ||
short_purpose="Original implementation of R2T2", | ||
reference="Diego Alonso-Álvarez, et al." | ||
"(2018, February 27). Solcore (Version 5.1.0). Zenodo." | ||
"http://doi.org/10.5281/zenodo.1185316", | ||
) | ||
def my_great_function(self): | ||
pass |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,17 +5,14 @@ | |
|
||
from r2t2.core import Biblio, BIBLIOGRAPHY, FunctionReference | ||
from r2t2.plain_text_parser import iter_parse_plain_text_references | ||
from r2t2.docstring_parser import ( | ||
CodeDocumentComment, | ||
iter_extract_docstring_from_files | ||
) | ||
from r2t2.docstring_parser import CodeDocumentComment, iter_extract_docstring_from_files | ||
|
||
|
||
LOGGER = logging.getLogger(__name__) | ||
|
||
|
||
DOCSTRING_SHORT_PURPOSE = 'automatically parsed from docstring' | ||
NOTEBOOK_SHORT_PURPOSE = 'automatically parsed from markdown cell' | ||
DOCSTRING_SHORT_PURPOSE = "automatically parsed from docstring" | ||
NOTEBOOK_SHORT_PURPOSE = "automatically parsed from markdown cell" | ||
|
||
|
||
def expand_file_list(path: Union[Path, str]) -> List[Path]: | ||
|
@@ -34,25 +31,25 @@ def get_function_reference_identifier(function_reference: FunctionReference) -> | |
|
||
|
||
def get_function_reference_from_docstring( | ||
docstring: CodeDocumentComment | ||
docstring: CodeDocumentComment, | ||
) -> FunctionReference: | ||
references = list(iter_parse_plain_text_references(docstring.text)) | ||
if docstring.lineno != 'n/a': | ||
if docstring.lineno != "n/a": | ||
purpose = DOCSTRING_SHORT_PURPOSE | ||
else: | ||
purpose = NOTEBOOK_SHORT_PURPOSE | ||
return FunctionReference( | ||
source=docstring.filename or '', | ||
source=docstring.filename or "", | ||
line=docstring.lineno or 0, | ||
name=docstring.name or '', | ||
package=docstring.package or "", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. minor: perhaps we should allow |
||
name=docstring.name or "", | ||
references=references, | ||
short_purpose=[purpose] * len(references) | ||
short_purpose=[purpose] * len(references), | ||
) | ||
|
||
|
||
def iter_parse_docstring_function_references_from_files( | ||
filenames: Iterable[Union[str, Path]], | ||
**kwargs | ||
filenames: Iterable[Union[str, Path]], **kwargs | ||
) -> Iterable[Tuple[str, FunctionReference]]: | ||
for docstring in iter_extract_docstring_from_files(filenames, **kwargs): | ||
function_reference = get_function_reference_from_docstring(docstring) | ||
|
@@ -62,9 +59,7 @@ def iter_parse_docstring_function_references_from_files( | |
|
||
|
||
def parse_and_add_docstring_references_from_files( | ||
filenames: Iterable[Union[str, Path]], | ||
biblio: Biblio = None, | ||
**kwargs | ||
filenames: Iterable[Union[str, Path]], biblio: Biblio = None, **kwargs | ||
): | ||
if biblio is None: | ||
biblio = BIBLIOGRAPHY | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: with that many arguments it might be good to use keyword arguments?