Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 232 #270

Merged
merged 10 commits into from
Dec 8, 2024
Merged

Task 232 #270

merged 10 commits into from
Dec 8, 2024

Conversation

maddycrim
Copy link
Contributor

@maddycrim maddycrim commented Dec 5, 2024

Task 232, proving each sorry in ProdAdicCompletions.baseChange.

Closes #232

Copy link
Collaborator

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've left some mostly stylistic comments.

FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Outdated Show resolved Hide resolved
@maddycrim
Copy link
Contributor Author

Could someone please remove the "awaiting author" label and mark this as "awaiting review"? It doesn't look like I have permission to change labels.

@kbuzzard
Copy link
Collaborator

kbuzzard commented Dec 8, 2024

Thanks a lot!

@kbuzzard kbuzzard merged commit 0bffc11 into ImperialCollegeLondon:main Dec 8, 2024
2 checks passed
WilliamCoram pushed a commit to WilliamCoram/FLT that referenced this pull request Dec 10, 2024
* completed task, planning to simplify code

* get rid of two rfls and a simp only

* get rid of rest of rfl

* change funext to refine to delete line

* Update FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean

Co-authored-by: Kevin Buzzard <[email protected]>

* Update FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean

Co-authored-by: Kevin Buzzard <[email protected]>

* Update FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean

Co-authored-by: Kevin Buzzard <[email protected]>

* Update FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean

Co-authored-by: Kevin Buzzard <[email protected]>

* make changes

---------

Co-authored-by: Kevin Buzzard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map from prod_v K_v to prod_w L_w
2 participants