-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task 232 #270
Merged
Merged
Task 232 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbuzzard
reviewed
Dec 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've left some mostly stylistic comments.
Co-authored-by: Kevin Buzzard <[email protected]>
Co-authored-by: Kevin Buzzard <[email protected]>
Co-authored-by: Kevin Buzzard <[email protected]>
Co-authored-by: Kevin Buzzard <[email protected]>
Could someone please remove the "awaiting author" label and mark this as "awaiting review"? It doesn't look like I have permission to change labels. |
Thanks a lot! |
WilliamCoram
pushed a commit
to WilliamCoram/FLT
that referenced
this pull request
Dec 10, 2024
* completed task, planning to simplify code * get rid of two rfls and a simp only * get rid of rest of rfl * change funext to refine to delete line * Update FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Co-authored-by: Kevin Buzzard <[email protected]> * Update FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Co-authored-by: Kevin Buzzard <[email protected]> * Update FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Co-authored-by: Kevin Buzzard <[email protected]> * Update FLT/DedekindDomain/FiniteAdeleRing/BaseChange.lean Co-authored-by: Kevin Buzzard <[email protected]> * make changes --------- Co-authored-by: Kevin Buzzard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task 232, proving each sorry in ProdAdicCompletions.baseChange.
Closes #232