Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compute the distributive Haar character of , , ℤ_[p] and ℚ_[p] #223

Conversation

YaelDillies
Copy link
Contributor

@YaelDillies YaelDillies commented Nov 18, 2024

Co-authored-by: Javier López-Contreras [email protected]


Copy link
Collaborator

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are two ideas which are (to me) distinct.

  1. Given a multiplicative group G acting as a DistribMulAction on an additive group A (e.g. A is a ring and G=A^*) with an additive Haar measure, there's a character G -> R_{>0}. Note that the key axiom is g . (a1 + a2) = g . a1 + g . a2, and G acts on A via additive group isos. Everything can be commutative here and the answer can still be interesting.

  2. Given a multiplicative group G acting on a multiplicative group H (e.g. H=G) with [IsScalarTower G H H] i.e. the axiom (g • h1) * h2 = g • (h1 * h2), and a multiplicative Haar measure on H, there's a character G -> R_{>0}. Note that G acts on H via things which aren't group isos, but they are bijections. Note also that nontriviality of this character implies that left and right Haar measures on H are different and in particular that H is not commutative.

"Modular character" is reserved in the literature for (2). I want (1). In this PR right now we have two files FLT/ForMathlib/DomMulActMeasure.lean and FLT/HaarMeasure/ModularCharacter.lean both with docstrings which seem to say basically the same thing (and both of which seem to be (1)), and both of which seem to use the words "modular character" for (1). We need to call it something else. How about distribHaarCharacter?

FLT/ForMathlib/MeasurableSpacePadics.lean Outdated Show resolved Hide resolved
FLT/HaarMeasure/Map.lean Outdated Show resolved Hide resolved
FLT/Mathlib/Data/ENNReal/Inv.lean Outdated Show resolved Hide resolved
@YaelDillies
Copy link
Contributor Author

Here are two ideas which are (to me) distinct. [...]

Yes, Javier and I ended up understanding what you meant by "This is not what the literature calls modular characters". Will update this PR later today

@YaelDillies YaelDillies force-pushed the tcc_18_nov_concrete_modular_haar_char branch 2 times, most recently from afe3aab to a7e5ea0 Compare December 2, 2024 21:26
@YaelDillies YaelDillies changed the title feat: progress on computing modular characters in concrete types feat: compute the distributive Haar character of , and ℚ_[p] Dec 2, 2024
@YaelDillies YaelDillies force-pushed the tcc_18_nov_concrete_modular_haar_char branch from ded579b to 125fd21 Compare December 3, 2024 19:03
Copy link
Collaborator

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This mostly looks fine, but I have an issue with one of the sorrys.

FLT/ForMathlib/MeasurableSpacePadics.lean Outdated Show resolved Hide resolved
FLT/ForMathlib/MeasurableSpacePadics.lean Outdated Show resolved Hide resolved
YaelDillies pushed a commit that referenced this pull request Dec 8, 2024
#223 made me realise that the definition of  `DistribHaarChar` was off by a "multiplicative sign" i.e. an inverse (for example `lemma distribHaarChar_real (x : ℝˣ) : distribHaarChar ℝ x = ‖(x : ℝ)‖₊⁻¹ := ...` is proved in that PR, which was not what was supposed to happen) . The sign in the Lean currently doesn't agree with the sign in the docstring or the sign in the associated Zulip discussion. This PR changes the definition to make it correct.
@YaelDillies YaelDillies force-pushed the tcc_18_nov_concrete_modular_haar_char branch from f7b29bf to 0536fa9 Compare December 8, 2024 17:21
FLT/HaarMeasure/ConcreteCharCalculations.lean Outdated Show resolved Hide resolved
FLT/Mathlib/MeasureTheory/Group/Action.lean Outdated Show resolved Hide resolved
FLT/Mathlib/NumberTheory/Padics/MeasurableSpacePadics.lean Outdated Show resolved Hide resolved
FLT/Mathlib/NumberTheory/Padics/PadicIntegers.lean Outdated Show resolved Hide resolved
FLT/Mathlib/NumberTheory/Padics/PadicIntegers.lean Outdated Show resolved Hide resolved
FLT/Mathlib/RingTheory/Norm/Defs.lean Outdated Show resolved Hide resolved
@YaelDillies YaelDillies force-pushed the tcc_18_nov_concrete_modular_haar_char branch from 0f42e94 to dc58a9e Compare December 9, 2024 15:22
@YaelDillies YaelDillies force-pushed the tcc_18_nov_concrete_modular_haar_char branch from 2400737 to 07cc225 Compare December 9, 2024 20:28
Copy link
Collaborator

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're nearly there. Can you maybe not add any more stuff so we can get this over the line?

FLT/HaarMeasure/DistribHaarChar/Padic.lean Outdated Show resolved Hide resolved
FLT/HaarMeasure/DistribHaarChar/Padic.lean Outdated Show resolved Hide resolved
FLT/HaarMeasure/DistribHaarChar/Padic.lean Outdated Show resolved Hide resolved
FLT/HaarMeasure/DistribHaarChar/RealComplex.lean Outdated Show resolved Hide resolved
FLT/Mathlib/MeasureTheory/Group/Action.lean Show resolved Hide resolved
FLT/Mathlib/NumberTheory/Padics/PadicIntegers.lean Outdated Show resolved Hide resolved
@YaelDillies YaelDillies changed the title feat: compute the distributive Haar character of , and ℚ_[p] feat: compute the distributive Haar character of , , ℤ_[p] and ℚ_[p] Dec 10, 2024
@kbuzzard
Copy link
Collaborator

Thanks so much for your work on this!

@kbuzzard kbuzzard merged commit c5f03bc into ImperialCollegeLondon:main Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants