-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compute the distributive Haar character of ℝ
, ℂ
, ℤ_[p]
and ℚ_[p]
#223
feat: compute the distributive Haar character of ℝ
, ℂ
, ℤ_[p]
and ℚ_[p]
#223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are two ideas which are (to me) distinct.
-
Given a multiplicative group G acting as a DistribMulAction on an additive group A (e.g. A is a ring and G=A^*) with an additive Haar measure, there's a character G -> R_{>0}. Note that the key axiom is
g . (a1 + a2) = g . a1 + g . a2
, and G acts on A via additive group isos. Everything can be commutative here and the answer can still be interesting. -
Given a multiplicative group G acting on a multiplicative group H (e.g. H=G) with [IsScalarTower G H H] i.e. the axiom
(g • h1) * h2 = g • (h1 * h2)
, and a multiplicative Haar measure on H, there's a character G -> R_{>0}. Note that G acts on H via things which aren't group isos, but they are bijections. Note also that nontriviality of this character implies that left and right Haar measures on H are different and in particular that H is not commutative.
"Modular character" is reserved in the literature for (2). I want (1). In this PR right now we have two files FLT/ForMathlib/DomMulActMeasure.lean
and FLT/HaarMeasure/ModularCharacter.lean
both with docstrings which seem to say basically the same thing (and both of which seem to be (1)), and both of which seem to use the words "modular character" for (1). We need to call it something else. How about distribHaarCharacter
?
Yes, Javier and I ended up understanding what you meant by "This is not what the literature calls modular characters". Will update this PR later today |
afe3aab
to
a7e5ea0
Compare
ℝ
, ℂ
and ℚ_[p]
ded579b
to
125fd21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This mostly looks fine, but I have an issue with one of the sorrys.
cb13592
to
f7b29bf
Compare
#223 made me realise that the definition of `DistribHaarChar` was off by a "multiplicative sign" i.e. an inverse (for example `lemma distribHaarChar_real (x : ℝˣ) : distribHaarChar ℝ x = ‖(x : ℝ)‖₊⁻¹ := ...` is proved in that PR, which was not what was supposed to happen) . The sign in the Lean currently doesn't agree with the sign in the docstring or the sign in the associated Zulip discussion. This PR changes the definition to make it correct.
f7b29bf
to
0536fa9
Compare
0f42e94
to
dc58a9e
Compare
2400737
to
07cc225
Compare
07cc225
to
3c4ef32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're nearly there. Can you maybe not add any more stuff so we can get this over the line?
ℝ
, ℂ
and ℚ_[p]
ℝ
, ℂ
, ℤ_[p]
and ℚ_[p]
Thanks so much for your work on this! |
Co-authored-by: Javier López-Contreras [email protected]
modularHaarChar
todistribHaarChar
#263