New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #10

Merged

utensil merged 1 commit into main from fix-ci

Dec 15, 2023

Contributor

utensil commented Dec 15, 2023

This PR handles a new lake subtlety, here is what happened:

A (me) set up lakefile to have

meta if get_config? env = some "dev" then
require «doc-gen4» from git
  "https://github.com/leanprover/doc-gen4" @ "main"

A ran lake -R -Kenv=dev update «doc-gen4» to ensure doc-gen4 in manifest, and committed this to Github
B (a mathematician) wanted to bump mathlib, ran lake update and committed, and CI is broken because lake sees no -Kenv=dev and removed doc-gen4 from manifest
CI failed with a prompt:

error: dependency '«doc-gen4»' not in manifest; use `lake update «doc-gen4»` to add it

so B runs lake update «doc-gen4», and the manifest doesn't change;

A has to run lake -R -Kenv=dev update «doc-gen4» and commit.


          Fix CI

015a2ab

Contributor Author

utensil commented Dec 15, 2023

I also wish to improve the instructions in README, so I opened this Zulip thread.

Will merge this PR first.

utensil merged commit a87931f into main

1 check passed

utensil deleted the fix-ci branch

December 15, 2023 04:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet