Fix nk_property not focusing when clicking mouse when the clicked property box is before the currently focused property box in the current window #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
Demonstration:
Current (notice when clicking the first box after the second one is focused, it immediately loses focus)
https://github.com/user-attachments/assets/a04e6fb8-e638-4b7f-b0d6-fee5c297a657
Fixed (this PR):
https://github.com/user-attachments/assets/e482c328-1bf3-4751-979c-6f7e63292b7a
Also ran paq.sh and added casts to match the changes in a previous PR (#682) to get rid of the type warnings introduced in that previous PR.
Update (2024-09-13):
There's another case not covered by this PR: if the content of the the edit field of an activated property was changed, focusing on an earlier property will cause the value to be discarded, while focusing on a later property will update the value. Fixing this inconsistent behavior will be a bit more involved the issue fixed in this PR.