Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nk_property not focusing when clicking mouse when the clicked property box is before the currently focused property box in the current window #688

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

xzn
Copy link
Contributor

@xzn xzn commented Sep 11, 2024

As titled.

Demonstration:

Current (notice when clicking the first box after the second one is focused, it immediately loses focus)
https://github.com/user-attachments/assets/a04e6fb8-e638-4b7f-b0d6-fee5c297a657

Fixed (this PR):
https://github.com/user-attachments/assets/e482c328-1bf3-4751-979c-6f7e63292b7a

Also ran paq.sh and added casts to match the changes in a previous PR (#682) to get rid of the type warnings introduced in that previous PR.

Update (2024-09-13):

There's another case not covered by this PR: if the content of the the edit field of an activated property was changed, focusing on an earlier property will cause the value to be discarded, while focusing on a later property will update the value. Fixing this inconsistent behavior will be a bit more involved the issue fixed in this PR.

@RobLoach
Copy link
Contributor

Thanks for updating this. Should we bring this in and tackle the follow up afterwards? Or wait until the other case is covered.

@xzn
Copy link
Contributor Author

xzn commented Sep 14, 2024

I can certainly make a follow up PR. To cover the other case I'll have to add some fields to the context struct so it remembers the previous edit variant. It's a bit more involved and you may want to review that separately. (If you can wait that's fine too, I can get to this later tonight)

Edit:

I found a bug in this PR: after dragging a property with mouse, dragging an earlier property with mouse will cause it to be permanently grabbed. Will fix this as well.
Nvm it's because i'm using an older version of the demo, apparently mouse grabbing has been updated since then haha.

@xzn
Copy link
Contributor Author

xzn commented Sep 15, 2024

Fixed the second case as well. If you want I can add an example to one of the examples though it seems to work fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants