Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve annotation styles #253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: improve annotation styles #253

wants to merge 2 commits into from

Conversation

pedrokohler
Copy link
Collaborator

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

igoroctaviano
igoroctaviano requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe the changes in the PR, address sonarcube issue and if possible, add documentation to new methods.

@igoroctaviano
Copy link
Collaborator

Please describe the changes in the PR, address sonarcube issue and if possible, add documentation to new methods.

@pedrokohler Also please update PR. I'll merge this PR and then cut a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoroctaviano igoroctaviano igoroctaviano requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedrokohler @igoroctaviano