Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCP url support #211

Merged
merged 3 commits into from
May 27, 2024
Merged

Add GCP url support #211

merged 3 commits into from
May 27, 2024

Conversation

igoroctaviano
Copy link
Collaborator

@igoroctaviano igoroctaviano commented May 17, 2024

#208

Allow using the following URL formats:

GCP path to a study

http://localhost:3000/projects/idc-external-031/locations/us-central1/datasets/slim-bulk-ann-images/dicomStores/slim-bulk-ann-images/study/2.25.68803095896966276583382138924964839274/series/1.3.6.1.4.1.5962.99.1.1163866303.1057408148.1637546438847.2.0

GCP path to a study + GCP query param pointing to the derived data store (annotations)

http://localhost:3000/projects/idc-external-031/locations/us-central1/datasets/slim-bulk-ann-images/dicomStores/slim-bulk-ann-images/study/2.25.68803095896966276583382138924964839274/series/1.3.6.1.4.1.5962.99.1.1163866303.1057408148.1637546438847.2.0?gcp=https://healthcare.googleapis.com/v1/projects/idc-external-031/locations/us-central1/datasets/slim-bulk-ann-annotations/dicomStores/slim-bulk-ann-annotations/dicomWeb

Copy link

github-actions bot commented May 17, 2024

Visit the preview URL for this PR (updated for commit 9e8895a):

https://idc-external-006--pr211-feat-issue-208-7d5vksfw.web.app

(expires Mon, 03 Jun 2024 14:50:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

@igoroctaviano
Copy link
Collaborator Author

@pedrokohler please review it and carefully test this against existent URL formats and the ones in the description.

Copy link
Collaborator

@pedrokohler pedrokohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a bug that you can reproduce as follows:

1- set your config file server to be https://proxy.imaging.datacommons.cancer.gov/current/viewer-only-no-downloads-see-tinyurl-dot-com-slash-3j3d9jyp/dicomWeb

2- open the worklist and find multiple studies from the dicom server above

3- now, in the same window, use your new feature and go to http://localhost:3000/projects/idc-external-031/locations/us-central1/datasets/slim-bulk-ann-images/dicomStores/slim-bulk-ann-images/study/2.25.68803095896966276583382138924964839274/series/1.3.6.1.4.1.5962.99.1.1163866303.1057408148.1637546438847.2.0

4- after load, go back to the worklist by clicking the worklist button on the menu (do not use the browser 'go back' button)

5- you'll see that all the studies from the original dicom server disappeared and you can only see the one from the server you set in the URL a moment before

I don't think this is expected behavior, it probably must be reset to the config file's url if you go back to the worklist

@igoroctaviano
Copy link
Collaborator Author

I found a bug that you can reproduce as follows:

1- set your config file server to be https://proxy.imaging.datacommons.cancer.gov/current/viewer-only-no-downloads-see-tinyurl-dot-com-slash-3j3d9jyp/dicomWeb

2- open the worklist and find multiple studies from the dicom server above

3- now, in the same window, use your new feature and go to http://localhost:3000/projects/idc-external-031/locations/us-central1/datasets/slim-bulk-ann-images/dicomStores/slim-bulk-ann-images/study/2.25.68803095896966276583382138924964839274/series/1.3.6.1.4.1.5962.99.1.1163866303.1057408148.1637546438847.2.0

4- after load, go back to the worklist by clicking the worklist button on the menu (do not use the browser 'go back' button)

5- you'll see that all the studies from the original dicom server disappeared and you can only see the one from the server you set in the URL a moment before

I don't think this is expected behavior, it probably must be reset to the config file's url if you go back to the worklist

@fedorov I want to hear your thoughts before changing this: When using the GCP URL do you expect the data source to be the one from the URL going forward or do you want to reset back to the original data source from the configuration when changing routes like going back to worklist? I guess the worklist will be disabled anyways for this GCP use case

@fedorov
Copy link
Member

fedorov commented May 24, 2024

That's an interesting question. I guess I would expect to see the worklist for the server specified in the URL, not the one from the original configuration. I personally would not expect it to reset to the original server. The intent of this feature is to switch to a new server, so I do not see a reason to go back to the one from the config.

@igoroctaviano
Copy link
Collaborator Author

That's an interesting question. I guess I would expect to see the worklist for the server specified in the URL, not the one from the original configuration. I personally would not expect it to reset to the original server. The intent of this feature is to switch to a new server, so I do not see a reason to go back to the one from the config.

@pedrokohler

@igoroctaviano igoroctaviano merged commit c5a886a into master May 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants