Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fractional segmentation #161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pedrokohler
Copy link
Collaborator

Fixing fractional segmentations:
1 - fixing color palette and maintaining transparent background
2 - removing color palette overlay for binary segmentations
3 - removing annoying zoom when activating segmentations

Addresses: ImagingDataCommons/slim#245

Binary segmentation now = no background and no color palette overlay:
image

Fractional segmentation now = no background and proper colors:
image

@pedrokohler
Copy link
Collaborator Author

@fedorov please check the PR description and let me know if that's all

Copy link

sonarcloud bot commented Nov 22, 2024

@fedorov
Copy link
Member

fedorov commented Nov 24, 2024

@pedrokohler nice work! Good to go from the description and the screenshot, once @igoroctaviano approves it!

@fedorov
Copy link
Member

fedorov commented Nov 24, 2024

Small nitpick - is it possible to include min and max pixel values in the color palette overlay for fractional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants