Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bun #485

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Add support for Bun #485

merged 2 commits into from
Feb 4, 2024

Conversation

will-stone
Copy link
Contributor

@will-stone will-stone commented Jan 23, 2024

Description

Support bun JS runtime. When a bun lockfile is detected, it'll display the Bun version (with an oven icon) along with Bun's version.

Motivation and Context

Closes #484

Screenshots (if appropriate)

How Has This Been Tested

I currently cannot seem to get this working. But maybe I'm setting something-up incorrectly.

  • I have tested using Linux.
  • I have tested using MacOS.

Checklist

  • I am ready to update the wiki accordingly.
  • I have updated the tests accordingly.

@will-stone will-stone mentioned this pull request Jan 23, 2024
@IlanCosman
Copy link
Owner

IlanCosman commented Jan 25, 2024

I undid the administrative stuff you did (leave that to me 😄), and I'm also not currently going to be making the node item not display when bun does. But the item works fine for me, I get a nice off-white version number with an oven icon. Really not sure why you're having problems.

@will-stone
Copy link
Contributor Author

Oh great 😄 Well, if you do a release I'll let you know, and we can fix through bug fixes if it's still not working for me.

@will-stone
Copy link
Contributor Author

I installed my version using Fisher: fisher install will-stone/tide@add-support-for-bun and it worked 🥳 Looks like this is ready to go.

CleanShot 2024-01-28 at 2  02 13@2x

@IlanCosman IlanCosman merged commit 57afe57 into IlanCosman:main Feb 4, 2024
5 checks passed
@will-stone will-stone deleted the add-support-for-bun branch February 4, 2024 18:17
@jorgebucaran
Copy link
Contributor

Thank you, @will-stone! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Bun
3 participants