Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar sync #808

Merged
merged 2 commits into from
May 7, 2024
Merged

Fix calendar sync #808

merged 2 commits into from
May 7, 2024

Conversation

anarute
Copy link
Member

@anarute anarute commented May 7, 2024

Comparing the dates with different formats was unreliable and not working well, so convert the date before comparing.

We don't need to sync events that are in the past, so sync only from one
month ago onwards.
It was generating bad false positives
@anarute anarute requested a review from dmtrek14 May 7, 2024 11:39
Copy link
Collaborator

@dmtrek14 dmtrek14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anarute anarute merged commit 09347e0 into main May 7, 2024
2 checks passed
@anarute anarute deleted the fix-calendar-sync branch May 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants