You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried uploading 3.1.0 to the marketplace and received a few errors and warnings. I wanted to get screenshots added along with updating dependencies to remove some warnings in the build process. This required some test updating too.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
So far I've got the unit tests passing but will test with our internal Zendesk.
Test Configuration:
Browser Version:
Operating System:
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
en.json: "name" "URL Builder" is already the name of an app in the Marketplace. Please choose something else. "URL Builder by Ibotta" would be ok.
en.json: "long_description" needs more detail. Typically a company boilerplate followed by what the integration does well. See instructions here and check out this blog article for best practices.
en.json: "installation_instructions" should be step by step on how to set this up and locate any settings that are required. See instructions here.
en.json: Markdown syntax is not quite right. Please be sure to use \n\n to denote line breaks and list items.
assets: Screenshots look blurry/stretched. As well, each image should be unique. Please retake.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
physik932
added
enhancement
Description
I tried uploading
3.1.0to the marketplace and received a few errors and warnings. I wanted to get screenshots added along with updating dependencies to remove some warnings in the build process. This required some test updating too.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
So far I've got the unit tests passing but will test with our internal Zendesk.
Test Configuration:
Checklist: