[SparseArraysBase] Rename SparseArrayInterface to SparseArraysBase
#1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase, absorb SparseArrayDOKs
mtfishman
changed the title
SparseArrayInterface to SparseArraysBase, absorb SparseArrayDOKsSparseArrayInterface to SparseArraysBase
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @lkdvos offline.
SparseArrayInterfacewas a bit of a misnomer since it includes both a sparse array interface, anAbstractSparseArraysupertype, and implementations ofAbstractArrayfunctionality. Maybe in the future we can split off the interface part into a separateSparseArrayInterfacebut that is farther down the line when it is more developed.Additionally, it doesn't make much sense to keep
SparseArrayDOKsas a separate module sinceSparseArrayInterface/SparseArraysBaserelies heavily on theSparseArrayDOKtype as a default output type of sparse operations, and moving it intoSparseArraysBasewill make development easier. I will do that move in a future PR.