[김영찬] 3차 과제 제출 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +22,16 @@ public ResponseEntity<Object> handleApiException(ApiException e) { | |||
| return makeErrorResponseEntity(e.getHttpStatus(), e.getMessage(), e.getCode()); | |||
| } | |||
|
|
|||
| @ExceptionHandler(MethodArgumentNotValidException.class) | |||
| public ResponseEntity<Object> handleMethodArgumentNotValidException(MethodArgumentNotValidException e){ | |||
| return makeErrorResponseEntity(HttpStatus.BAD_REQUEST, e.getBindingResult().getAllErrors().get(0).getDefaultMessage(), "POST-001"); | |||
There was a problem hiding this comment.
ErrorCode를 사용하지 않고, 직접 POST-001 처럼 code를 명시한 전역 예외 핸들러를 구현하신 이유가 궁금합니다!
backend/src/main/java/cotato/backend/domains/post/PostBulkRepository.java
Show resolved
Hide resolved
|
|
||
| } catch (Exception e) { | ||
| log.error("Failed to save estates by excel", e); | ||
| throw ApiException.from(INTERNAL_SERVER_ERROR); | ||
| } | ||
| } | ||
|
|
||
| public FindPostResponse findPostById(Long id) { |
There was a problem hiding this comment.
읽기 전용이면 @Transactional(readOnly = true)를 붙여봐도 좋을 거 같아요.!
| show_sql: true | ||
| format_sql: true | ||
| logging.level: | ||
| org.hibernate.SQL: debug |
There was a problem hiding this comment.
password를 빼 두신 걸 보니 보안을 고려해서 빼둔 거겠죠?
만약 h2 비번이 진짜 없는거면 이 부분은 git ignore 처리해주시면 좋을 거 같아요!
|
|
||
| @Override | ||
| Page<Post> findAll(Pageable pageable); | ||
|
|
There was a problem hiding this comment.
이 코드에서 @Repository나 @Override를 명시하신 이유가 궁금합니다!
u-genuine
reviewed
Nov 28, 2024
| } | ||
|
|
||
| @GetMapping("/list") | ||
| public ResponseEntity<?> findPosts(@PageableDefault(size = 10, sort = "views", direction = Sort.Direction.DESC) |
There was a problem hiding this comment.
@PageableDefault 어노테이션으로도 처리가 가능하네요 !! 배워갑니당
chanmin-00
reviewed
Nov 28, 2024
| } | ||
|
|
||
| @ExceptionHandler(NoSuchElementException.class) | ||
| public ResponseEntity<Object> handleNoSuchElementException(NoSuchElementException e){ |
|
|
||
| @Entity | ||
| @Getter | ||
| @Setter |
There was a problem hiding this comment.
무분별한 setter 사용은 지양하는게 좋다고 들었습니다!
|
|
||
| private final JdbcTemplate jdbcTemplate; | ||
|
|
||
| public void saveAllByExcel(List<Post> posts) { |
There was a problem hiding this comment.
데이터베이스 저장 작업을 하기 때문에 Transactional 어노테이션을 고려하는 것도 좋을 거 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
평소에 고민되던 부분 중 하나가 저는 Dto에서 엔티티로 변환할 때, 엔티티 클래스 내의 한 곳에서 정적 팩토리 메서드들을 오버로딩하여 생성하는 방법을 선택하고 있습니다. Dto에서 메서드를 선언하는 분들도 있는 것 같아서, 취향 차이인 것인지 특별히 좋은 이유가 있는 것인지 의견을 구하고 싶습니다.