Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zsh image for ncs-zephyr #7

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat: add zsh image for ncs-zephyr #7

merged 1 commit into from
Oct 11, 2024

Conversation

MarkoSagadin
Copy link
Collaborator

@MarkoSagadin MarkoSagadin commented Oct 10, 2024

Description

This PR introduces a new ZSH-based Docker image for enhanced developer experience. It adds a new build stage to the existing Dockerfile, creates a ZSH image with additional tools and configurations, and updates the GitHub workflow to build and push this new image.

Areas of interest for the reviewer

Try building and running this image locally.

For that you need to:

git clone https://github.com/IRNAS/irnas-docker-software.git
cd irnas-docker-software
git checkout feature/zsh
cd ncs-zephyr
./build_zsh.sh

# Wait a bit
./run.sh <path to some application's west top directory>

Tell me if you like what you see, check the changes in the Docker file, I have also added my usual aliases.

Checklist

  • My code follows the style guidelines as defined by IRNAS.
  • I have performed a self-review of my code.
  • My changes generate no new warnings.
  • I added/updated source code documentation for all newly added or changed functions.
  • I updated all customer-facing technical documentation. - This PR mainly affects internal development tools and processes.

After-review steps

Code author will merge the branch

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MarkoSagadin and the rest of your teammates on Graphite Graphite

@MarkoSagadin MarkoSagadin marked this pull request as ready for review October 10, 2024 13:11
@MarkoSagadin MarkoSagadin requested a review from KajbaM October 10, 2024 13:12
Copy link

@KajbaM KajbaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful!
It brings tear to my eye!
No longer need to deal with path or virtual shell environment?
LIFE CHANGING!
I feel like new man using this Docker image and you should be proud as the author!

IMMACULATE WORK!
This will make my life so much easier, that I will finally potentially maybe turn into somewhat decent developer <3

Thank you!

Added via Giphy

@MarkoSagadin MarkoSagadin merged commit 2260436 into main Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants