Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #29

Merged
merged 5 commits into from
Nov 23, 2024
Merged

PHP 8.4 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0afa79
Update CI to use new PHP version 8.4
loicsapone Oct 2, 2024
2d3e7c8
Update dev env to PHP 8.4
loicsapone Oct 2, 2024
0c17127
Add PHP_CS_FIXER_IGNORE_ENV=1 to CS Fixer job
loicsapone Nov 23, 2024
b2d4dbf
CS Fixer
loicsapone Nov 23, 2024
c40dd07
Upgrade rector
loicsapone Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.3
php-version: 8.4
coverage: none

- name: Install dependencies
Expand All @@ -27,7 +27,7 @@ jobs:
dependency-versions: ${{ matrix.dependencies }}

- name: PHP-CS-Fixer
run: php vendor/bin/php-cs-fixer fix --dry-run --diff --no-ansi
run: PHP_CS_FIXER_IGNORE_ENV=1 php vendor/bin/php-cs-fixer fix --dry-run --diff --no-ansi

phpstan:
runs-on: ubuntu-latest
Expand All @@ -38,7 +38,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.3
php-version: 8.4
coverage: none

- name: Install dependencies
Expand All @@ -58,7 +58,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.3
php-version: 8.4
coverage: none

- name: Install dependencies
Expand All @@ -73,7 +73,7 @@ jobs:
strategy:
matrix:
operating-system: [ 'ubuntu-latest' ]
php-version: [ '8.1', '8.2', '8.3' ]
php-version: [ '8.1', '8.2', '8.3', '8.4' ]

runs-on: ${{ matrix.operating-system }}

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"mikey179/vfsstream": "^1.6",
"phpstan/phpstan": "^1.9",
"phpunit/phpunit": "^10.0",
"rector/rector": "^0.15"
"rector/rector": "^1.2"
},
"autoload": {
"psr-4": { "IQ2i\\DataImporter\\": "src" }
Expand Down
2 changes: 1 addition & 1 deletion docker/php/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#syntax=docker/dockerfile:1.4

FROM php:8.3-cli-alpine
FROM php:8.4-cli-alpine

COPY --from=mlocati/php-extension-installer --link /usr/bin/install-php-extensions /usr/local/bin/
COPY --from=composer/composer:2-bin --link /composer /usr/bin/composer
Expand Down
2 changes: 1 addition & 1 deletion tests/DataImporterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public function testWithUnreadableArchivePath()

public function testAsyncProcessor()
{
$bus = new class() implements MessageBusInterface {
$bus = new class implements MessageBusInterface {
public array $messages = [];

public array $stamps = [];
Expand Down
Loading