This repository has been archived by the owner on May 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Parser idea #30
Open
Gelbpunkt
wants to merge
11
commits into
IOMirea:master
Choose a base branch
from
Gelbpunkt:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Parser idea #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
======================================
Coverage 53.9% 53.9%
======================================
Files 14 14
Lines 371 371
======================================
Hits 200 200
Misses 171 171
Continue to review full report at Codecov.
|
That's the next step when parser is done |
Not sure how this should work under the hood. Are you only going to work on parser or you can suggest changes to library internals as well? |
Fogapod
reviewed
Nov 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first take at a parser for a human-readable protocol. Targets #15
It's WIP and I'll start separating it onto multiple files when the syntax itself gets accepted.
There's 5 actions: CONNECT, PING, INFO, REQUEST, RESPOND
All can be called simply with
ACTION;
, except REQUEST and RESPOND.Those require arguments, e.g.
REQUEST 'json goes here';
.Optionally, they take a
FROM/TO
argument that is eitherALL
or an integer of e.g. the receiver.CONN, REQ and RESP are aliases.
Examples:
I made a simple interactive example. You can run it like this:
Then type your queries and it'll output the actual query string or syntax errors.
Note: Syntax is subject to change, I might go for
REQUEST 'handler_func' WITH 'parameter1', 'parameter2', 3 FROM ALL;
. But that would remove the JSON-ish syntax