Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: /gatherings 필터링 관련 버그 수정 #206

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

HMRyu
Copy link
Contributor

@HMRyu HMRyu commented Oct 16, 2024

✏️ 작업 내용

  • 날짜로 필터링 시 오늘 이후의 날짜를 설정할 수 없었던 버그 수정
  • 필터링 시 '참여 인원 순' 글자가 깨지는 버그 수정

📷 스크린샷

날짜 필터링

스크린샷 2024-10-16 18 23 30

참여 인원 순

스크린샷 2024-10-16 18 23 07

✍️ 사용법

🎸 기타

확인 후 피드백 부탁드립니다!

@HMRyu HMRyu added the ⚒️ Fix 버그 수정 label Oct 16, 2024
@HMRyu HMRyu self-assigned this Oct 16, 2024
@HMRyu HMRyu linked an issue Oct 16, 2024 that may be closed by this pull request
@@ -53,7 +53,7 @@ const FilterSort = ({
data-testid='filter-component'
>
<IconSort className='${iconClass} h-24 w-24' />
<span className='hidden md:mr-8 md:inline'>{text}</span>
<span className='hidden whitespace-nowrap md:mr-8 md:inline'>{text}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 다른 페이지에서 5글자인 것들 테스트해보셨나요??

Copy link
Contributor Author

@HMRyu HMRyu Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인해볼게요! => 다른 곳에서도 정상적으로 되는 것 같습니다!

@@ -83,7 +83,7 @@ const FilterDate = ({
<CalendarModal
initialSelectedData={selectedDate}
handleClickButtons={handleClickButtons}
CalendarProps={{ changeEndDays: 0 }}
CalendarProps={{ changeEndDays: undefined }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@yunchaeney yunchaeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link
Contributor

@hakyoung12 hakyoung12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 고생하셨습니다!

@HMRyu HMRyu merged commit e9ba9d3 into develop Oct 17, 2024
4 checks passed
@HMRyu HMRyu deleted the fix/homin/KAN-131-gatherings-filtering branch October 21, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚒️ Fix 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: /gatherings 필터링 관련 이슈
4 participants