fix: logout timer 버그 수정 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakyoung12
requested review from
BeMatthewsong,
HMRyu and
yunchaeney
as code owners
hakyoung12
commented
Oct 16, 2024
Comment on lines
+14
to
+16
| if (!userData) { | ||
| redirect('/gatherings'); | ||
| } |
There was a problem hiding this comment.
미들웨어에서 검사하던 로직 레아아웃 파일로 이동
Comment on lines
+21
to
+24
| const expirationTime = getTokenExpirationTime(token); // 만료시간 | ||
| const currentTime = Date.now(); // 현재시간 | ||
| const remainingTime = Math.max(0, expirationTime - currentTime); // 남은 시간 계산 | ||
| setTimeLeft(Math.floor(remainingTime / 1000)); // 초 단위로 변환 |
There was a problem hiding this comment.
원래는 토큰을 발급받은 뒤에 만료시간인 3600초에서 1초씩 빼는 로직으로 구현되었으나
현재는 서버에서 받아온 토큰에서 만료시간을 가져온 뒤에 현재시간에서 빼는 로직으로 리팩토링하였습니다.
이를 통해 로컬스토리지를 사용할 필요가 없어졌고 창이 닫히거나 비활성화 되었을 때 로컬스토리지에 로그아웃까지 남은 시간이 남아있는 문제를 해결했습니다.
| @@ -32,7 +30,7 @@ const ProfileEditModal = ({ | |||
| setProfileInput(e.target.value); | |||
| }; | |||
|
|
|||
| const isValid = profileInput !== user?.companyName && profileInput !== ''; | |||
| const isValid = profileInput !== ''; | |||
There was a problem hiding this comment.
회사명이 공백이 아닐때만 제출이 가능하게 하여 이미지와 회사명 둘 중 하나만 바꿔도 프로필을 바꿀 수 있습니다.
yunchaeney
approved these changes
Oct 16, 2024
| @@ -14,7 +14,7 @@ export async function GET(req: Request) { | |||
| const token = await getCookie('token'); | |||
|
|
|||
| const response = await fetch( | |||
| `${process.env.NEXT_PUBLIC_API_BASE_URL}/gatherings/joined?offset=${offset}&limit=${limit}`, | |||
| `${process.env.NEXT_PUBLIC_API_BASE_URL}/gatherings/joined?offset=${offset}&limit=${limit}&sortOrder=desc`, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 작업 내용
📷 스크린샷
프로필 수정
Oct-16-2024.17-24-56.mov
close #197