Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: gnb 컴포넌트 테스트코드 작성 #191

Merged
merged 5 commits into from
Oct 16, 2024
Merged

test: gnb 컴포넌트 테스트코드 작성 #191

merged 5 commits into from
Oct 16, 2024

Conversation

hakyoung12
Copy link
Contributor

✏️ 작업 내용

  • Gnb 테스트코드 작성
  • TokenExpirationTimerLayout 테스트코드 작성
  • UserStatus 테스트코드 작성

📷 스크린샷

Gnb

스크린샷 2024-10-15 오후 4 40 58

TokenExpirationTimerLayout

스크린샷 2024-10-15 오후 4 41 23

UserStatus

스크린샷 2024-10-15 오후 4 41 43

close #47

@hakyoung12 hakyoung12 added the 🧪 Test 테스트 label Oct 15, 2024
@hakyoung12 hakyoung12 self-assigned this Oct 15, 2024
BeMatthewsong
BeMatthewsong reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@BeMatthewsong BeMatthewsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 코드 작성할 때 보면 도움이 되는 코드들이 많네요 ! LGTM 👏

HMRyu
HMRyu approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@HMRyu HMRyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 테스트 코드를 엄청 능숙하게 잘 짜시는 것 같아요...!

고생하셨습니다..! 👍

yunchaeney
yunchaeney approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@yunchaeney yunchaeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

@hakyoung12 hakyoung12 merged commit 687f09e into develop Oct 16, 2024
4 checks passed
@BeMatthewsong BeMatthewsong deleted the test/go/KAN-46-gnb branch October 16, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunchaeney yunchaeney yunchaeney approved these changes

@BeMatthewsong BeMatthewsong BeMatthewsong approved these changes

@HMRyu HMRyu HMRyu approved these changes

Assignees

@hakyoung12 hakyoung12

Labels
🧪 Test 테스트
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: 학영) 공통 컴포넌트 테스트 코드 작성
4 participants
@hakyoung12 @HMRyu @BeMatthewsong @yunchaeney