review: fix(control-flow): Handle synchronized statement in CFG #5740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWitt
approved these changes
Apr 6, 2024
|
LGTM will merge |
I-Al-Istannen
requested changes
Apr 8, 2024
spoon-control-flow/src/main/java/fr/inria/controlflow/ControlFlowBuilder.java
Show resolved
Hide resolved
| @@ -798,7 +798,11 @@ public <T, S> void visitCtSwitchExpression(CtSwitchExpression<T, S> switchExpres | |||
|
|
|||
| @Override | |||
| public void visitCtSynchronized(CtSynchronized synchro) { | |||
| ControlFlowNode expressionNode = new ControlFlowNode(synchro.getExpression(), result, BranchKind.STATEMENT); | |||
| tryAddEdge(lastNode, expressionNode); | |||
| lastNode = expressionNode; | |||
There was a problem hiding this comment.
Do we want to preserve the synchronized statement itself in the graph? I.e. call defaultAction(synchro, BranchKind.STATEMENT) or w/e somewhere? Currently it looks like the synchronized is unrolled and no trace of it is left?
There was a problem hiding this comment.
Ideally yes, but in the current CFG model this is not possible in any way I like. This is one of the things I would like to improve with the redesign started in #5742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a
synchronizedstatement is completely ignored in the CFG. This PR adds it to the CFG properly.