Add timber #6
Open
Add timber #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngjinc
approved these changes
Dec 26, 2022
| @@ -100,6 +101,7 @@ class SignUpActivity : BindingActivity<ActivitySignUpBinding>(R.layout.activity_ | |||
|
|
|||
| viewModel.signupResult.observe(this) { | |||
| startActivity(Intent(this,SignInActivity::class.java)) | |||
| Toast.makeText(this,getString(R.string.sign_up_success_toast_msg), Toast.LENGTH_LONG).show() | |||
There was a problem hiding this comment.
control + alt + L 을 눌러서 코드 정렬을 시켜봅시당!
| @@ -33,11 +33,10 @@ class SignupViewModel: ViewModel() { | |||
| response: Response<ResponseSignupDTO> | |||
| ) { | |||
| _signupResult.value = response.body() | |||
| Log.d("회원가입 성공", "${response.body()}") | |||
| val first_name: String, | ||
| val last_name: String, | ||
| @SerialName("first_name") | ||
| val firstName: String, |
| @@ -22,7 +22,7 @@ | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:layout_marginTop="60dp" | |||
| android:text="Welcome to SOPT" | |||
| android:text="@string/sign_in_title" | |||
youngjinc
reviewed
Dec 26, 2022
Comment on lines
+24
to
+26
| if(BuildConfig.DEBUG){ | ||
| Timber.plant(Timber.DebugTree()) | ||
| } |
There was a problem hiding this comment.
애플리케이션 클래스 생성해서 onCreate()에 넣어주세요! 애플리케이션이 실행될 때 딱 한번 실행됩니다! 현재 코드 상에서는 홈프래그먼트가 실행될 때 마다 해당 코드가 실행될 것입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.