[REFACTOR]: 리팩토링 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1urrrr
requested changes
Dec 21, 2022
| @@ -1,9 +1,11 @@ | |||
| package org.sopt.sample | |||
| package org.sopt.sample.presentation.activity | |||
There was a problem hiding this comment.
presentation 패키지를 activity, adapter, fragment로 분리하셨네요!
저희 앱잼 때 사용할 방식처럼 뷰마다 패키지를 만들어보면 좋을 것 같아요~
(제 레포지토리 참고하셔도 좋을 것 같아요 🙃)
EX) presentation 안에 signin, signup, main
| @@ -1,9 +1,11 @@ | |||
| package org.sopt.sample | |||
| package org.sopt.sample.presentation.activity | |||
There was a problem hiding this comment.
HomeActivity는 지금은 필요하지 않는 뷰 같은데 관련된 파일들을 삭제하면 더 깔끔할 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.